Skip to content

Commit

Permalink
neigh: Kill neigh_ops->hh_output
Browse files Browse the repository at this point in the history
It's always dev_queue_xmit().

Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
davem330 committed Jul 17, 2011
1 parent 0895b08 commit 47ec132
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 14 deletions.
1 change: 0 additions & 1 deletion include/net/neighbour.h
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ struct neigh_ops {
void (*error_report)(struct neighbour *, struct sk_buff*);
int (*output)(struct sk_buff*);
int (*connected_output)(struct sk_buff*);
int (*hh_output)(struct sk_buff*);
int (*queue_xmit)(struct sk_buff*);
};

Expand Down
1 change: 0 additions & 1 deletion net/atm/clip.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ static const struct neigh_ops clip_neigh_ops = {
.error_report = clip_neigh_error,
.output = dev_queue_xmit,
.connected_output = dev_queue_xmit,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand Down
4 changes: 2 additions & 2 deletions net/core/neighbour.c
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ static void neigh_connect(struct neighbour *neigh)

hh = &neigh->hh;
if (hh->hh_len)
hh->hh_output = neigh->ops->hh_output;
hh->hh_output = dev_queue_xmit;
}

static void neigh_periodic_work(struct work_struct *work)
Expand Down Expand Up @@ -1222,7 +1222,7 @@ static void neigh_hh_init(struct neighbour *n, struct dst_entry *dst)
goto end;

if (n->nud_state & NUD_CONNECTED)
hh->hh_output = n->ops->hh_output;
hh->hh_output = dev_queue_xmit;
else
hh->hh_output = n->ops->output;

Expand Down
3 changes: 0 additions & 3 deletions net/decnet/dn_neigh.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ static const struct neigh_ops dn_long_ops = {
.error_report = dn_long_error_report,
.output = dn_long_output,
.connected_output = dn_long_output,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand All @@ -76,7 +75,6 @@ static const struct neigh_ops dn_short_ops = {
.error_report = dn_short_error_report,
.output = dn_short_output,
.connected_output = dn_short_output,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand All @@ -88,7 +86,6 @@ static const struct neigh_ops dn_phase3_ops = {
.error_report = dn_short_error_report, /* Can use short version here */
.output = dn_phase3_output,
.connected_output = dn_phase3_output,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit
};

Expand Down
4 changes: 0 additions & 4 deletions net/ipv4/arp.c
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ static const struct neigh_ops arp_generic_ops = {
.error_report = arp_error_report,
.output = neigh_resolve_output,
.connected_output = neigh_connected_output,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand All @@ -148,15 +147,13 @@ static const struct neigh_ops arp_hh_ops = {
.error_report = arp_error_report,
.output = neigh_resolve_output,
.connected_output = neigh_resolve_output,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

static const struct neigh_ops arp_direct_ops = {
.family = AF_INET,
.output = dev_queue_xmit,
.connected_output = dev_queue_xmit,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand All @@ -166,7 +163,6 @@ static const struct neigh_ops arp_broken_ops = {
.error_report = arp_error_report,
.output = neigh_compat_output,
.connected_output = neigh_compat_output,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand Down
3 changes: 0 additions & 3 deletions net/ipv6/ndisc.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ static const struct neigh_ops ndisc_generic_ops = {
.error_report = ndisc_error_report,
.output = neigh_resolve_output,
.connected_output = neigh_connected_output,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand All @@ -117,7 +116,6 @@ static const struct neigh_ops ndisc_hh_ops = {
.error_report = ndisc_error_report,
.output = neigh_resolve_output,
.connected_output = neigh_resolve_output,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand All @@ -126,7 +124,6 @@ static const struct neigh_ops ndisc_direct_ops = {
.family = AF_INET6,
.output = dev_queue_xmit,
.connected_output = dev_queue_xmit,
.hh_output = dev_queue_xmit,
.queue_xmit = dev_queue_xmit,
};

Expand Down

0 comments on commit 47ec132

Please sign in to comment.