Skip to content

Commit

Permalink
lockref: use arch_mutex_cpu_relax() in CMPXCHG_LOOP()
Browse files Browse the repository at this point in the history
Make use of arch_mutex_cpu_relax() so architectures can override the
default cpu_relax() semantics.
This is especially useful for s390, where cpu_relax() means that we
yield() the current (virtual) cpu and therefore is very expensive,
and would contradict the whole purpose of the lockless cmpxchg loop.

Signed-off-by: Heiko Carstens <[email protected]>
  • Loading branch information
heicarst committed Sep 28, 2013
1 parent 083986e commit 491f6f8
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion lib/lockref.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@
# define cmpxchg64_relaxed cmpxchg64
#endif

/*
* Allow architectures to override the default cpu_relax() within CMPXCHG_LOOP.
* This is useful for architectures with an expensive cpu_relax().
*/
#ifndef arch_mutex_cpu_relax
# define arch_mutex_cpu_relax() cpu_relax()
#endif

/*
* Note that the "cmpxchg()" reloads the "old" value for the
* failure case.
Expand All @@ -28,7 +36,7 @@
if (likely(old.lock_count == prev.lock_count)) { \
SUCCESS; \
} \
cpu_relax(); \
arch_mutex_cpu_relax(); \
} \
} while (0)

Expand Down

0 comments on commit 491f6f8

Please sign in to comment.