Skip to content

Commit

Permalink
Merge branch 'work.uaccess2' of git://git.kernel.org/pub/scm/linux/ke…
Browse files Browse the repository at this point in the history
…rnel/git/viro/vfs

Pull uaccess.h prepwork from Al Viro:
 "Preparations to tree-wide switch to use of linux/uaccess.h (which,
  obviously, will allow to start unifying stuff for real). The last step
  there, ie

    PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*<asm/uaccess.h>'
    sed -i -e "s!$PATT!#include <linux/uaccess.h>!" \
            `git grep -l "$PATT"|grep -v ^include/linux/uaccess.h`

  is not taken here - I would prefer to do it once just before or just
  after -rc1.  However, everything should be ready for it"

* 'work.uaccess2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
  remove a stray reference to asm/uaccess.h in docs
  sparc64: separate extable_64.h, switch elf_64.h to it
  score: separate extable.h, switch module.h to it
  mips: separate extable.h, switch module.h to it
  x86: separate extable.h, switch sections.h to it
  remove stray include of asm/uaccess.h from cacheflush.h
  mn10300: remove a bogus processor.h->uaccess.h include
  xtensa: split uaccess.h into C and asm sides
  bonding: quit messing with IOCTL
  kill __kernel_ds_p off
  mn10300: finish verify_area() off
  frv: move HAVE_ARCH_UNMAPPED_AREA to pgtable.h
  exceptions: detritus removal
  • Loading branch information
torvalds committed Oct 12, 2016
2 parents 6b25e21 + aa7eb9a commit 4cdf8db
Show file tree
Hide file tree
Showing 38 changed files with 262 additions and 270 deletions.
2 changes: 1 addition & 1 deletion Documentation/DocBook/kernel-hacking.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ printk(KERN_INFO "my ip: %pI4\n", &amp;ipaddress);
<function>get_user()</function>
/
<function>put_user()</function>
<filename class="headerfile">include/asm/uaccess.h</filename>
<filename class="headerfile">include/linux/uaccess.h</filename>
</title>

<para>
Expand Down
1 change: 0 additions & 1 deletion arch/arm/mm/fault.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ static inline int fsr_fs(unsigned int fsr)
#endif

void do_bad_area(unsigned long addr, unsigned int fsr, struct pt_regs *regs);
unsigned long search_exception_table(unsigned long addr);
void early_abt_enable(void);

#endif /* __ARCH_ARM_FAULT_H */
1 change: 1 addition & 0 deletions arch/frv/include/asm/pgtable.h
Original file line number Diff line number Diff line change
Expand Up @@ -522,5 +522,6 @@ extern void __init pgtable_cache_init(void);
#ifndef __ASSEMBLY__
extern void __init paging_init(void);
#endif /* !__ASSEMBLY__ */
#define HAVE_ARCH_UNMAPPED_AREA

#endif /* _ASM_PGTABLE_H */
1 change: 0 additions & 1 deletion arch/frv/include/asm/segment.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ typedef struct {
#define get_ds() (KERNEL_DS)
#define get_fs() (__current_thread_info->addr_limit)
#define segment_eq(a, b) ((a).seg == (b).seg)
#define __kernel_ds_p() segment_eq(get_fs(), KERNEL_DS)
#define get_addr_limit() (get_fs().seg)

#define set_fs(_x) \
Expand Down
2 changes: 0 additions & 2 deletions arch/frv/include/asm/uaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
#include <asm/segment.h>
#include <asm/sections.h>

#define HAVE_ARCH_UNMAPPED_AREA /* we decide where to put mmaps */

#define __ptr(x) ((unsigned long __force *)(x))

#define VERIFY_READ 0
Expand Down
3 changes: 0 additions & 3 deletions arch/m68k/include/asm/uaccess_no.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ struct exception_table_entry
unsigned long insn, fixup;
};

/* Returns 0 if exception not found and fixup otherwise. */
extern unsigned long search_exception_table(unsigned long);


/*
* These are the main single-value transfer routines. They automatically
Expand Down
3 changes: 0 additions & 3 deletions arch/microblaze/include/asm/uaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ struct exception_table_entry {
unsigned long insn, fixup;
};

/* Returns 0 if exception not found and fixup otherwise. */
extern unsigned long search_exception_table(unsigned long);

#ifndef CONFIG_MMU

/* Check against bounds of physical memory */
Expand Down
13 changes: 13 additions & 0 deletions arch/mips/include/asm/extable.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#ifndef _ASM_EXTABLE_H
#define _ASM_EXTABLE_H

struct exception_table_entry
{
unsigned long insn;
unsigned long nextinsn;
};

struct pt_regs;
extern int fixup_exception(struct pt_regs *regs);

#endif
2 changes: 1 addition & 1 deletion arch/mips/include/asm/module.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <linux/list.h>
#include <linux/elf.h>
#include <asm/uaccess.h>
#include <asm/extable.h>

struct mod_arch_specific {
/* Data Bus Error exception tables */
Expand Down
9 changes: 1 addition & 8 deletions arch/mips/include/asm/uaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <linux/thread_info.h>
#include <linux/string.h>
#include <asm/asm-eva.h>
#include <asm/extable.h>

/*
* The fs value determines whether argument validity checking should be
Expand Down Expand Up @@ -1485,12 +1486,4 @@ static inline long strnlen_user(const char __user *s, long n)
return res;
}

struct exception_table_entry
{
unsigned long insn;
unsigned long nextinsn;
};

extern int fixup_exception(struct pt_regs *regs);

#endif /* _ASM_UACCESS_H */
1 change: 1 addition & 0 deletions arch/mips/lasat/picvue_proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#include <linux/timer.h>
#include <linux/mutex.h>
#include <linux/uaccess.h>

#include "picvue.h"

Expand Down
1 change: 0 additions & 1 deletion arch/mn10300/include/asm/processor.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include <asm/page.h>
#include <asm/ptrace.h>
#include <asm/cpu-regs.h>
#include <asm/uaccess.h>
#include <asm/current.h>

/* Forward declaration, a strange C thing */
Expand Down
7 changes: 0 additions & 7 deletions arch/mn10300/include/asm/uaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
#define get_ds() (KERNEL_DS)
#define get_fs() (current_thread_info()->addr_limit)
#define set_fs(x) (current_thread_info()->addr_limit = (x))
#define __kernel_ds_p() (current_thread_info()->addr_limit.seg == 0x9FFFFFFF)

#define segment_eq(a, b) ((a).seg == (b).seg)

Expand Down Expand Up @@ -72,12 +71,6 @@ static inline int ___range_ok(unsigned long addr, unsigned int size)
#define access_ok(type, addr, size) (__range_ok((addr), (size)) == 0)
#define __access_ok(addr, size) (__range_ok((addr), (size)) == 0)

static inline int verify_area(int type, const void *addr, unsigned long size)
{
return access_ok(type, addr, size) ? 0 : -EFAULT;
}


/*
* The exception table consists of pairs of addresses: the first is the
* address of an instruction that is allowed to fault, and the second is
Expand Down
6 changes: 3 additions & 3 deletions arch/mn10300/kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ static int restore_sigcontext(struct pt_regs *regs,
struct fpucontext *buf;
err |= __get_user(buf, &sc->fpucontext);
if (buf) {
if (verify_area(VERIFY_READ, buf, sizeof(*buf)))
if (!access_ok(VERIFY_READ, buf, sizeof(*buf)))
goto badframe;
err |= fpu_restore_sigcontext(buf);
}
Expand All @@ -98,7 +98,7 @@ asmlinkage long sys_sigreturn(void)
long d0;

frame = (struct sigframe __user *) current_frame()->sp;
if (verify_area(VERIFY_READ, frame, sizeof(*frame)))
if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))
goto badframe;
if (__get_user(set.sig[0], &frame->sc.oldmask))
goto badframe;
Expand Down Expand Up @@ -130,7 +130,7 @@ asmlinkage long sys_rt_sigreturn(void)
long d0;

frame = (struct rt_sigframe __user *) current_frame()->sp;
if (verify_area(VERIFY_READ, frame, sizeof(*frame)))
if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))
goto badframe;
if (__copy_from_user(&set, &frame->uc.uc_sigmask, sizeof(set)))
goto badframe;
Expand Down
4 changes: 0 additions & 4 deletions arch/openrisc/include/asm/uaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,6 @@ struct exception_table_entry {
unsigned long insn, fixup;
};

/* Returns 0 if exception not found and fixup otherwise. */
extern unsigned long search_exception_table(unsigned long);
extern void sort_exception_table(void);

/*
* These are the main single-value transfer routines. They automatically
* use the right size if we just have the right pointer type.
Expand Down
11 changes: 11 additions & 0 deletions arch/score/include/asm/extable.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#ifndef _ASM_SCORE_EXTABLE_H
#define _ASM_SCORE_EXTABLE_H

struct exception_table_entry {
unsigned long insn;
unsigned long fixup;
};

struct pt_regs;
extern int fixup_exception(struct pt_regs *regs);
#endif
2 changes: 1 addition & 1 deletion arch/score/include/asm/module.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define _ASM_SCORE_MODULE_H

#include <linux/list.h>
#include <asm/uaccess.h>
#include <asm/extable.h>
#include <asm-generic/module.h>

struct mod_arch_specific {
Expand Down
8 changes: 1 addition & 7 deletions arch/score/include/asm/uaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/thread_info.h>
#include <asm/extable.h>

#define VERIFY_READ 0
#define VERIFY_WRITE 1
Expand Down Expand Up @@ -420,12 +421,5 @@ static inline long strnlen_user(const char __user *str, long len)
return __strnlen_user(str, len);
}

struct exception_table_entry {
unsigned long insn;
unsigned long fixup;
};

extern int fixup_exception(struct pt_regs *regs);

#endif /* __SCORE_UACCESS_H */

2 changes: 0 additions & 2 deletions arch/sh/include/asm/uaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,6 @@ struct exception_table_entry {
#endif

int fixup_exception(struct pt_regs *regs);
/* Returns 0 if exception not found and fixup.unit otherwise. */
unsigned long search_exception_table(unsigned long addr);
const struct exception_table_entry *search_exception_tables(unsigned long addr);

extern void *set_exception_table_vec(unsigned int vec, void *handler);
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/include/asm/elf_64.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <asm/ptrace.h>
#include <asm/processor.h>
#include <asm/uaccess.h>
#include <asm/extable_64.h>
#include <asm/spitfire.h>

/*
Expand Down
20 changes: 20 additions & 0 deletions arch/sparc/include/asm/extable_64.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#ifndef __ASM_EXTABLE64_H
#define __ASM_EXTABLE64_H
/*
* The exception table consists of pairs of addresses: the first is the
* address of an instruction that is allowed to fault, and the second is
* the address at which the program should continue. No registers are
* modified, so it is entirely up to the continuation code to figure out
* what to do.
*
* All the routines below use bits of fixup code that are out of line
* with the main instruction path. This means when everything is well,
* we don't even have to jump over them. Further, they do not intrude
* on our cache or tlb entries.
*/

struct exception_table_entry {
unsigned int insn, fixup;
};

#endif
18 changes: 1 addition & 17 deletions arch/sparc/include/asm/uaccess_64.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include <asm/asi.h>
#include <asm/spitfire.h>
#include <asm-generic/uaccess-unaligned.h>
#include <asm/extable_64.h>
#endif

#ifndef __ASSEMBLY__
Expand Down Expand Up @@ -81,23 +82,6 @@ static inline int access_ok(int type, const void __user * addr, unsigned long si
return 1;
}

/*
* The exception table consists of pairs of addresses: the first is the
* address of an instruction that is allowed to fault, and the second is
* the address at which the program should continue. No registers are
* modified, so it is entirely up to the continuation code to figure out
* what to do.
*
* All the routines below use bits of fixup code that are out of line
* with the main instruction path. This means when everything is well,
* we don't even have to jump over them. Further, they do not intrude
* on our cache or tlb entries.
*/

struct exception_table_entry {
unsigned int insn, fixup;
};

void __ret_efault(void);
void __retl_efault(void);

Expand Down
1 change: 0 additions & 1 deletion arch/x86/include/asm/cacheflush.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
/* Caches aren't brain-dead on the intel. */
#include <asm-generic/cacheflush.h>
#include <asm/special_insns.h>
#include <asm/uaccess.h>

/*
* The set_memory_* API can be used to change various attributes of a virtual
Expand Down
35 changes: 35 additions & 0 deletions arch/x86/include/asm/extable.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#ifndef _ASM_X86_EXTABLE_H
#define _ASM_X86_EXTABLE_H
/*
* The exception table consists of triples of addresses relative to the
* exception table entry itself. The first address is of an instruction
* that is allowed to fault, the second is the target at which the program
* should continue. The third is a handler function to deal with the fault
* caused by the instruction in the first field.
*
* All the routines below use bits of fixup code that are out of line
* with the main instruction path. This means when everything is well,
* we don't even have to jump over them. Further, they do not intrude
* on our cache or tlb entries.
*/

struct exception_table_entry {
int insn, fixup, handler;
};
struct pt_regs;

#define ARCH_HAS_RELATIVE_EXTABLE

#define swap_ex_entry_fixup(a, b, tmp, delta) \
do { \
(a)->fixup = (b)->fixup + (delta); \
(b)->fixup = (tmp).fixup - (delta); \
(a)->handler = (b)->handler + (delta); \
(b)->handler = (tmp).handler - (delta); \
} while (0)

extern int fixup_exception(struct pt_regs *regs, int trapnr);
extern bool ex_has_fault_handler(unsigned long ip);
extern void early_fixup_exception(struct pt_regs *regs, int trapnr);

#endif
2 changes: 1 addition & 1 deletion arch/x86/include/asm/sections.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define _ASM_X86_SECTIONS_H

#include <asm-generic/sections.h>
#include <asm/uaccess.h>
#include <asm/extable.h>

extern char __brk_base[], __brk_limit[];
extern struct exception_table_entry __stop___ex_table[];
Expand Down
32 changes: 1 addition & 31 deletions arch/x86/include/asm/uaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <asm/asm.h>
#include <asm/page.h>
#include <asm/smap.h>
#include <asm/extable.h>

#define VERIFY_READ 0
#define VERIFY_WRITE 1
Expand Down Expand Up @@ -90,37 +91,6 @@ static inline bool __chk_range_not_ok(unsigned long addr, unsigned long size, un
#define access_ok(type, addr, size) \
likely(!__range_not_ok(addr, size, user_addr_max()))

/*
* The exception table consists of triples of addresses relative to the
* exception table entry itself. The first address is of an instruction
* that is allowed to fault, the second is the target at which the program
* should continue. The third is a handler function to deal with the fault
* caused by the instruction in the first field.
*
* All the routines below use bits of fixup code that are out of line
* with the main instruction path. This means when everything is well,
* we don't even have to jump over them. Further, they do not intrude
* on our cache or tlb entries.
*/

struct exception_table_entry {
int insn, fixup, handler;
};

#define ARCH_HAS_RELATIVE_EXTABLE

#define swap_ex_entry_fixup(a, b, tmp, delta) \
do { \
(a)->fixup = (b)->fixup + (delta); \
(b)->fixup = (tmp).fixup - (delta); \
(a)->handler = (b)->handler + (delta); \
(b)->handler = (tmp).handler - (delta); \
} while (0)

extern int fixup_exception(struct pt_regs *regs, int trapnr);
extern bool ex_has_fault_handler(unsigned long ip);
extern void early_fixup_exception(struct pt_regs *regs, int trapnr);

/*
* These are the main single-value transfer routines. They automatically
* use the right size if we just have the right pointer type.
Expand Down
Loading

0 comments on commit 4cdf8db

Please sign in to comment.