Skip to content

Commit

Permalink
x86/PCI: Use generic pci_mmap_resource_range()
Browse files Browse the repository at this point in the history
Signed-off-by: David Woodhouse <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
  • Loading branch information
dwmw2 authored and bjorn-helgaas committed Apr 20, 2017
1 parent 69c701e commit 5c2d5ce
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 48 deletions.
1 change: 1 addition & 0 deletions arch/x86/include/asm/pci.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ int pcibios_set_irq_routing(struct pci_dev *dev, int pin, int irq);

#define HAVE_PCI_MMAP
#define arch_can_pci_mmap_wc() pat_enabled()
#define ARCH_GENERIC_PCI_MMAP_RESOURCE

#ifdef CONFIG_PCI
extern void early_quirks(void);
Expand Down
48 changes: 0 additions & 48 deletions arch/x86/pci/i386.c
Original file line number Diff line number Diff line change
Expand Up @@ -406,51 +406,3 @@ void __init pcibios_resource_survey(void)
*/
ioapic_insert_resources();
}

static const struct vm_operations_struct pci_mmap_ops = {
.access = generic_access_phys,
};

int pci_mmap_page_range(struct pci_dev *dev, int bar,
struct vm_area_struct *vma,
enum pci_mmap_state mmap_state, int write_combine)
{
unsigned long prot;

/* I/O space cannot be accessed via normal processor loads and
* stores on this platform.
*/
if (mmap_state == pci_mmap_io)
return -EINVAL;

prot = pgprot_val(vma->vm_page_prot);

/*
* Return error if pat is not enabled and write_combine is requested.
* Caller can followup with UC MINUS request and add a WC mtrr if there
* is a free mtrr slot.
*/
if (!pat_enabled() && write_combine)
return -EINVAL;

if (pat_enabled() && write_combine)
prot |= cachemode2protval(_PAGE_CACHE_MODE_WC);
else if (pat_enabled() || boot_cpu_data.x86 > 3)
/*
* ioremap() and ioremap_nocache() defaults to UC MINUS for now.
* To avoid attribute conflicts, request UC MINUS here
* as well.
*/
prot |= cachemode2protval(_PAGE_CACHE_MODE_UC_MINUS);

vma->vm_page_prot = __pgprot(prot);

if (io_remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff,
vma->vm_end - vma->vm_start,
vma->vm_page_prot))
return -EAGAIN;

vma->vm_ops = &pci_mmap_ops;

return 0;
}

0 comments on commit 5c2d5ce

Please sign in to comment.