usb: gadget: uvc: Use GFP_ATOMIC under spin lock

Found using the following semantic patch: <spml> @@ @@ spin_lock_irqsave(...); ... when != spin_unlock_irqrestore(...); * GFP_KERNEL </spml> Signed-off-by: Cyril Roelandt <[email protected]> Signed-off-by: Laurent Pinchart <[email protected]> Tested-by: Bhupesh Sharma <[email protected]> Signed-off-by: Felipe Balbi <[email protected]>
kyagi · Mar 18, 2013 · 6854bcd · 6854bcd
1 parent 326b0e6
commit 6854bcd
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/drivers/usb/gadget/uvc_video.c b/drivers/usb/gadget/uvc_video.c
@@ -314,7 +314,8 @@ uvc_video_pump(struct uvc_video *video)
 		video->encode(req, video, buf);
 
 		/* Queue the USB request */
-		if ((ret = usb_ep_queue(video->ep, req, GFP_KERNEL)) < 0) {
+		ret = usb_ep_queue(video->ep, req, GFP_ATOMIC);
+		if (ret < 0) {
 			printk(KERN_INFO "Failed to queue request (%d)\n", ret);
 			usb_ep_set_halt(video->ep);
 			spin_unlock_irqrestore(&video->queue.irqlock, flags);