Skip to content

Commit

Permalink
leds: sunfire: Use platform_register/unregister_drivers()
Browse files Browse the repository at this point in the history
These new helpers simplify implementing multi-driver modules and
properly handle failure to register one driver by unregistering all
previously registered drivers.

Signed-off-by: Thierry Reding <[email protected]>
Signed-off-by: Jacek Anaszewski <[email protected]>
  • Loading branch information
thierryreding authored and janaszewski committed Jan 4, 2016
1 parent 8891161 commit 6e25e64
Showing 1 changed file with 7 additions and 16 deletions.
23 changes: 7 additions & 16 deletions drivers/leds/leds-sunfire.c
Original file line number Diff line number Diff line change
Expand Up @@ -234,28 +234,19 @@ static struct platform_driver sunfire_fhc_led_driver = {
},
};

static struct platform_driver * const drivers[] = {
&sunfire_clockboard_led_driver,
&sunfire_fhc_led_driver,
};

static int __init sunfire_leds_init(void)
{
int err = platform_driver_register(&sunfire_clockboard_led_driver);

if (err) {
pr_err("Could not register clock board LED driver\n");
return err;
}

err = platform_driver_register(&sunfire_fhc_led_driver);
if (err) {
pr_err("Could not register FHC LED driver\n");
platform_driver_unregister(&sunfire_clockboard_led_driver);
}

return err;
return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
}

static void __exit sunfire_leds_exit(void)
{
platform_driver_unregister(&sunfire_clockboard_led_driver);
platform_driver_unregister(&sunfire_fhc_led_driver);
platform_unregister_drivers(drivers, ARRAY_SIZE(drivers));
}

module_init(sunfire_leds_init);
Expand Down

0 comments on commit 6e25e64

Please sign in to comment.