NFSv4: Don't call put_rpccred() under the rcu_read_lock()

put_rpccred() can sleep. Fixes: 8f649c3 ("NFSv4: Fix the locking in nfs_inode_reclaim_delegation()") Cc: [email protected] # 2.6.35+ Signed-off-by: Trond Myklebust <[email protected]>
kyagi · Mar 2, 2015 · 7c0af9f · 7c0af9f
1 parent fa92336
commit 7c0af9f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
@@ -181,8 +181,8 @@ void nfs_inode_reclaim_delegation(struct inode *inode, struct rpc_cred *cred,
 			clear_bit(NFS_DELEGATION_NEED_RECLAIM,
 				  &delegation->flags);
 			spin_unlock(&delegation->lock);
-			put_rpccred(oldcred);
 			rcu_read_unlock();
+			put_rpccred(oldcred);
 			trace_nfs4_reclaim_delegation(inode, res->delegation_type);
 		} else {
 			/* We appear to have raced with a delegation return. */