Skip to content

Commit

Permalink
ACPI / video: Move dmi_check_system from module_init to acpi_video_re…
Browse files Browse the repository at this point in the history
…gister

When builtin there is no guarantee in which order module_init functions
are run, so acpi_video_register() may get called from the i915 driver
(if it is also builtin) before acpi_video_init() gets called, resulting
in the dmi quirks not yet being parsed.

This commit moves the dmi_check_system() call to acpi_video_register(),
so that we can be sure the dmi quirks have always been applied before
probing.

Signed-off-by: Hans de Goede <[email protected]>
Acked-by: Darren Hart <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
  • Loading branch information
jwrdegoede authored and rafaeljw committed Jun 18, 2015
1 parent 93a291d commit 7ee33ba
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/acpi/acpi_video.c
Original file line number Diff line number Diff line change
Expand Up @@ -383,21 +383,21 @@ acpi_video_device_lcd_set_level(struct acpi_video_device *device, int level)
*/

static int bqc_offset_aml_bug_workaround;
static int __init video_set_bqc_offset(const struct dmi_system_id *d)
static int video_set_bqc_offset(const struct dmi_system_id *d)
{
bqc_offset_aml_bug_workaround = 9;
return 0;
}

static int __init video_disable_backlight_sysfs_if(
static int video_disable_backlight_sysfs_if(
const struct dmi_system_id *d)
{
if (disable_backlight_sysfs_if == -1)
disable_backlight_sysfs_if = 1;
return 0;
}

static struct dmi_system_id video_dmi_table[] __initdata = {
static struct dmi_system_id video_dmi_table[] = {
/*
* Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121
*/
Expand Down Expand Up @@ -1977,6 +1977,8 @@ int acpi_video_register(void)
mutex_init(&video_list_lock);
INIT_LIST_HEAD(&video_bus_head);

dmi_check_system(video_dmi_table);

ret = acpi_bus_register_driver(&acpi_video_bus);
if (ret)
return ret;
Expand Down Expand Up @@ -2042,8 +2044,6 @@ static int __init acpi_video_init(void)
if (acpi_disabled)
return 0;

dmi_check_system(video_dmi_table);

if (intel_opregion_present())
return 0;

Expand Down

0 comments on commit 7ee33ba

Please sign in to comment.