Skip to content

Commit

Permalink
Revert unintentional "volatile" changes in ipc/msg.c
Browse files Browse the repository at this point in the history
Commit 5a06a36 ("[PATCH] ipc/msg.c:
clean up coding style") breaks fakeroot on Alpha (variously hangs or
oopses), according to a report by Falk Hueffner.

The fact that the code seems to rely on compiler access ordering through
the use of "volatile" is a pretty certain sign that the code has locking
problems, and we should fix those properly and then remove the whole
"volatile" entirely.

But in the meantime, the movement of "volatile" was unintentional, and
should be reverted.

Cc: Falk Hueffner <[email protected]>
Cc: Andrew Morton <[email protected]>
Acked-by: Ingo Molnar <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Linus Torvalds committed Nov 4, 2006
1 parent ddac0d3 commit 80491eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ipc/msg.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ struct msg_receiver {
long r_msgtype;
long r_maxsize;

volatile struct msg_msg *r_msg;
struct msg_msg *volatile r_msg;
};

/* one msg_sender for each sleeping sender */
Expand Down

0 comments on commit 80491eb

Please sign in to comment.