Skip to content

Commit

Permalink
block: set request_list for request
Browse files Browse the repository at this point in the history
Legacy queue sets request's request_list, mq doesn't. This makes mq does
the same thing, so we can find cgroup of a request. Note, we really
only use blkg field of request_list, it's pointless to allocate mempool
for request_list in mq case.

Signed-off-by: Shaohua Li <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
shligit authored and axboe committed Oct 10, 2017
1 parent eca8b53 commit 85acb3b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ static void free_request_size(void *element, void *data)
int blk_init_rl(struct request_list *rl, struct request_queue *q,
gfp_t gfp_mask)
{
if (unlikely(rl->rq_pool))
if (unlikely(rl->rq_pool) || q->mq_ops)
return 0;

rl->q = q;
Expand Down
5 changes: 5 additions & 0 deletions block/blk-mq.c
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,9 @@ void blk_mq_free_request(struct request *rq)

wbt_done(q->rq_wb, &rq->issue_stat);

if (blk_rq_rl(rq))
blk_put_rl(blk_rq_rl(rq));

clear_bit(REQ_ATOM_STARTED, &rq->atomic_flags);
clear_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);
if (rq->tag != -1)
Expand Down Expand Up @@ -1532,6 +1535,8 @@ static void blk_mq_bio_to_request(struct request *rq, struct bio *bio)
{
blk_init_request_from_bio(rq, bio);

blk_rq_set_rl(rq, blk_get_rl(rq->q, bio));

blk_account_io_start(rq, true);
}

Expand Down

0 comments on commit 85acb3b

Please sign in to comment.