Skip to content

Commit

Permalink
apparmor: make free_profile available outside of policy.c
Browse files Browse the repository at this point in the history
Signed-off-by: John Johansen <[email protected]>
  • Loading branch information
John Johansen committed Aug 14, 2013
1 parent 742058b commit 8651e1d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
1 change: 1 addition & 0 deletions security/apparmor/include/policy.h
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ struct aa_namespace *aa_find_namespace(struct aa_namespace *root,
void aa_free_replacedby_kref(struct kref *kref);
struct aa_profile *aa_alloc_profile(const char *name);
struct aa_profile *aa_new_null_profile(struct aa_profile *parent, int hat);
void aa_free_profile(struct aa_profile *profile);
void aa_free_profile_kref(struct kref *kref);
struct aa_profile *aa_find_child(struct aa_profile *parent, const char *name);
struct aa_profile *aa_lookup_profile(struct aa_namespace *ns, const char *name);
Expand Down
9 changes: 4 additions & 5 deletions security/apparmor/policy.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,6 @@ static struct aa_namespace *alloc_namespace(const char *prefix,
return NULL;
}

static void free_profile(struct aa_profile *profile);
/**
* free_namespace - free a profile namespace
* @ns: the namespace to free (MAYBE NULL)
Expand All @@ -324,7 +323,7 @@ static void free_namespace(struct aa_namespace *ns)
aa_put_namespace(ns->parent);

ns->unconfined->ns = NULL;
free_profile(ns->unconfined);
aa_free_profile(ns->unconfined);
kzfree(ns);
}

Expand Down Expand Up @@ -568,7 +567,7 @@ void aa_free_replacedby_kref(struct kref *kref)
}

/**
* free_profile - free a profile
* aa_free_profile - free a profile
* @profile: the profile to free (MAYBE NULL)
*
* Free a profile, its hats and null_profile. All references to the profile,
Expand All @@ -577,7 +576,7 @@ void aa_free_replacedby_kref(struct kref *kref)
* If the profile was referenced from a task context, free_profile() will
* be called from an rcu callback routine, so we must not sleep here.
*/
static void free_profile(struct aa_profile *profile)
void aa_free_profile(struct aa_profile *profile)
{
AA_DEBUG("%s(%p)\n", __func__, profile);

Expand Down Expand Up @@ -612,7 +611,7 @@ static void aa_free_profile_rcu(struct rcu_head *head)
if (p->flags & PFLAG_NS_COUNT)
free_namespace(p->ns);
else
free_profile(p);
aa_free_profile(p);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions security/apparmor/policy_unpack.c
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ static struct aa_profile *unpack_profile(struct aa_ext *e)
else if (!name)
name = "unknown";
audit_iface(profile, name, "failed to unpack profile", e, error);
aa_put_profile(profile);
aa_free_profile(profile);

return ERR_PTR(error);
}
Expand Down Expand Up @@ -763,7 +763,7 @@ int aa_unpack(void *udata, size_t size, struct list_head *lh, const char **ns)

error = verify_profile(profile);
if (error) {
aa_put_profile(profile);
aa_free_profile(profile);
goto fail;
}

Expand Down

0 comments on commit 8651e1d

Please sign in to comment.