Skip to content

Commit

Permalink
Revert "crypto: arm64/sha - Add constant operand modifier to ASM_EXPORT"
Browse files Browse the repository at this point in the history
This reverts commit 42ae292.  It
causes a regression with older versions of gcc.  The consensus is
that this should instead be fixed in clang.

Reported-by: Paul Gortmaker <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
herbertx committed Apr 24, 2017
1 parent 116591f commit 899f35f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion arch/arm64/crypto/sha1-ce-glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include <linux/module.h>

#define ASM_EXPORT(sym, val) \
asm(".globl " #sym "; .set " #sym ", %c0" :: "i"(val));
asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val));

MODULE_DESCRIPTION("SHA1 secure hash using ARMv8 Crypto Extensions");
MODULE_AUTHOR("Ard Biesheuvel <[email protected]>");
Expand Down
2 changes: 1 addition & 1 deletion arch/arm64/crypto/sha2-ce-glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include <linux/module.h>

#define ASM_EXPORT(sym, val) \
asm(".globl " #sym "; .set " #sym ", %c0" :: "i"(val));
asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val));

MODULE_DESCRIPTION("SHA-224/SHA-256 secure hash using ARMv8 Crypto Extensions");
MODULE_AUTHOR("Ard Biesheuvel <[email protected]>");
Expand Down

0 comments on commit 899f35f

Please sign in to comment.