Skip to content

Commit

Permalink
Merge branch 'core-fixes-for-linus-2' of git://git.kernel.org/pub/scm…
Browse files Browse the repository at this point in the history
…/linux/kernel/git/tip/linux-2.6-tip

* 'core-fixes-for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  generic-ipi: fix stack and rcu interaction bug in smp_call_function_mask(), fix
  • Loading branch information
torvalds committed Aug 12, 2008
2 parents 1c89ac5 + c2fc119 commit 9634885
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ void generic_smp_call_function_interrupt(void)
*/
smp_wmb();
data->csd.flags &= ~CSD_FLAG_WAIT;
} else
}
if (data->csd.flags & CSD_FLAG_ALLOC)
call_rcu(&data->rcu_head, rcu_free_call_data);
}
rcu_read_unlock();
Expand Down Expand Up @@ -289,10 +290,11 @@ static void smp_call_function_mask_quiesce_stack(cpumask_t mask)

data.func = quiesce_dummy;
data.info = NULL;
data.flags = CSD_FLAG_WAIT;

for_each_cpu_mask(cpu, mask)
for_each_cpu_mask(cpu, mask) {
data.flags = CSD_FLAG_WAIT;
generic_exec_single(cpu, &data);
}
}

/**
Expand Down Expand Up @@ -371,7 +373,7 @@ int smp_call_function_mask(cpumask_t mask, void (*func)(void *), void *info,
if (wait) {
csd_flag_wait(&data->csd);
if (unlikely(slowpath))
smp_call_function_mask_quiesce_stack(allbutself);
smp_call_function_mask_quiesce_stack(mask);
}

return 0;
Expand Down

0 comments on commit 9634885

Please sign in to comment.