Skip to content

Commit

Permalink
cpufreq: scpi-cpufreq: signedness bug in scpi_get_dvfs_info()
Browse files Browse the repository at this point in the history
The "domain" variable needs to be signed for the error handling to work.

Fixes: 8def310 (cpufreq: arm_big_little: add SCPI interface driver)
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Viresh Kumar <[email protected]>
Acked-by: Sudeep Holla <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
  • Loading branch information
Dan Carpenter authored and rafaeljw committed Dec 24, 2015
1 parent 4ef7675 commit a7def56
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/cpufreq/scpi-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;

static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
{
u8 domain = topology_physical_package_id(cpu_dev->id);
int domain = topology_physical_package_id(cpu_dev->id);

if (domain < 0)
return ERR_PTR(-EINVAL);
Expand Down

0 comments on commit a7def56

Please sign in to comment.