Skip to content

Commit

Permalink
cdc-acm: delete obsolete debug messages
Browse files Browse the repository at this point in the history
Some debug messages merely provide a function trace without
additional debug data. They predate ftrace and can be replaced
by it. Drop them without replacement.

Signed-off-by: Oliver Neukum <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
oneukum authored and gregkh committed Sep 9, 2016
1 parent ce8bb34 commit ab57f86
Showing 1 changed file with 3 additions and 17 deletions.
20 changes: 3 additions & 17 deletions drivers/usb/class/cdc-acm.c
Original file line number Diff line number Diff line change
Expand Up @@ -492,8 +492,6 @@ static int acm_tty_install(struct tty_driver *driver, struct tty_struct *tty)
struct acm *acm;
int retval;

dev_dbg(tty->dev, "%s\n", __func__);

acm = acm_get_by_minor(tty->index);
if (!acm)
return -ENODEV;
Expand All @@ -515,8 +513,6 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp)
{
struct acm *acm = tty->driver_data;

dev_dbg(tty->dev, "%s\n", __func__);

return tty_port_open(&acm->port, tty, filp);
}

Expand Down Expand Up @@ -545,8 +541,6 @@ static int acm_port_activate(struct tty_port *port, struct tty_struct *tty)
int retval = -ENODEV;
int i;

dev_dbg(&acm->control->dev, "%s\n", __func__);

mutex_lock(&acm->mutex);
if (acm->disconnected)
goto disconnected;
Expand Down Expand Up @@ -607,8 +601,6 @@ static void acm_port_destruct(struct tty_port *port)
{
struct acm *acm = container_of(port, struct acm, port);

dev_dbg(&acm->control->dev, "%s\n", __func__);

acm_release_minor(acm);
usb_put_intf(acm->control);
kfree(acm->country_codes);
Expand All @@ -622,8 +614,6 @@ static void acm_port_shutdown(struct tty_port *port)
struct acm_wb *wb;
int i;

dev_dbg(&acm->control->dev, "%s\n", __func__);

/*
* Need to grab write_lock to prevent race with resume, but no need to
* hold it due to the tty-port initialised flag.
Expand Down Expand Up @@ -654,21 +644,21 @@ static void acm_port_shutdown(struct tty_port *port)
static void acm_tty_cleanup(struct tty_struct *tty)
{
struct acm *acm = tty->driver_data;
dev_dbg(&acm->control->dev, "%s\n", __func__);

tty_port_put(&acm->port);
}

static void acm_tty_hangup(struct tty_struct *tty)
{
struct acm *acm = tty->driver_data;
dev_dbg(&acm->control->dev, "%s\n", __func__);

tty_port_hangup(&acm->port);
}

static void acm_tty_close(struct tty_struct *tty, struct file *filp)
{
struct acm *acm = tty->driver_data;
dev_dbg(&acm->control->dev, "%s\n", __func__);

tty_port_close(&acm->port, tty, filp);
}

Expand Down Expand Up @@ -1533,8 +1523,6 @@ static void stop_data_traffic(struct acm *acm)
{
int i;

dev_dbg(&acm->control->dev, "%s\n", __func__);

usb_kill_urb(acm->ctrlurb);
for (i = 0; i < ACM_NW; i++)
usb_kill_urb(acm->wb[i].urb);
Expand All @@ -1551,8 +1539,6 @@ static void acm_disconnect(struct usb_interface *intf)
struct tty_struct *tty;
int i;

dev_dbg(&intf->dev, "%s\n", __func__);

/* sibling interface is already cleaning up */
if (!acm)
return;
Expand Down

0 comments on commit ab57f86

Please sign in to comment.