Skip to content

Commit

Permalink
ieee802154: 6lowpan: add check for reserved dispatch
Browse files Browse the repository at this point in the history
This patch adds checks for reserved dispatch value. When we have a
reserved dispatch value we should drop the skb immediately.

Reviewed-by: Stefan Schmidt <[email protected]>
Signed-off-by: Alexander Aring <[email protected]>
Signed-off-by: Marcel Holtmann <[email protected]>
  • Loading branch information
alexaring authored and holtmann committed Sep 17, 2015
1 parent ad66360 commit c6fdbba
Showing 1 changed file with 15 additions and 1 deletion.
16 changes: 15 additions & 1 deletion net/ieee802154/6lowpan/rx.c
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,19 @@ static inline bool lowpan_is_nalp(u8 dispatch)
return (dispatch & LOWPAN_DISPATCH_FIRST) == LOWPAN_DISPATCH_NALP;
}

/* Lookup for reserved dispatch values at:
* https://www.iana.org/assignments/_6lowpan-parameters/_6lowpan-parameters.xhtml#_6lowpan-parameters-1
*
* Last Updated: 2015-01-22
*/
static inline bool lowpan_is_reserved(u8 dispatch)
{
return ((dispatch >= 0x44 && dispatch <= 0x4F) ||
(dispatch >= 0x51 && dispatch <= 0x5F) ||
(dispatch >= 0xc8 && dispatch <= 0xdf) ||
(dispatch >= 0xe8 && dispatch <= 0xff));
}

/* lowpan_rx_h_check checks on generic 6LoWPAN requirements
* in MAC and 6LoWPAN header.
*
Expand All @@ -271,7 +284,8 @@ static inline bool lowpan_rx_h_check(struct sk_buff *skb)
if (unlikely(!skb->len))
return false;

if (lowpan_is_nalp(*skb_network_header(skb)))
if (lowpan_is_nalp(*skb_network_header(skb)) ||
lowpan_is_reserved(*skb_network_header(skb)))
return false;

return true;
Expand Down

0 comments on commit c6fdbba

Please sign in to comment.