Skip to content

Commit

Permalink
ceph_sync_{,direct_}write: fix an oops on ceph_osdc_new_request() fai…
Browse files Browse the repository at this point in the history
…lure

ceph_osdc_put_request(ERR_PTR(-error)) oopses.  What we want there
is break, not goto out.

Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Apr 12, 2014
1 parent ccad236 commit eab8723
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/ceph/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ ceph_sync_direct_write(struct kiocb *iocb, const struct iovec *iov,
false);
if (IS_ERR(req)) {
ret = PTR_ERR(req);
goto out;
break;
}

num_pages = calc_pages_for(page_align, len);
Expand Down Expand Up @@ -718,7 +718,7 @@ static ssize_t ceph_sync_write(struct kiocb *iocb, const struct iovec *iov,
false);
if (IS_ERR(req)) {
ret = PTR_ERR(req);
goto out;
break;
}

/*
Expand Down

0 comments on commit eab8723

Please sign in to comment.