Skip to content

Commit

Permalink
IB/qib: fix false-postive maybe-uninitialized warning
Browse files Browse the repository at this point in the history
aarch64-linux-gcc-7 complains about code it doesn't fully understand:

drivers/infiniband/hw/qib/qib_iba7322.c: In function 'qib_7322_txchk_change':
include/asm-generic/bitops/non-atomic.h:105:35: error: 'shadow' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The code is right, and despite trying hard, I could not come up with a version
that I liked better than just adding a fake initialization here to shut up the
warning.

Fixes: f931551 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters")
Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: Ira Weiny <[email protected]>
Signed-off-by: Doug Ledford <[email protected]>
  • Loading branch information
arndb authored and dledford committed Mar 25, 2017
1 parent ea174c9 commit f6aafac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/qib/qib_iba7322.c
Original file line number Diff line number Diff line change
Expand Up @@ -7068,7 +7068,7 @@ static void qib_7322_txchk_change(struct qib_devdata *dd, u32 start,
unsigned long flags;

while (wait) {
unsigned long shadow;
unsigned long shadow = 0;
int cstart, previ = -1;

/*
Expand Down

0 comments on commit f6aafac

Please sign in to comment.