Skip to content

Commit

Permalink
arm64: kvm: report original PAR_EL1 upon panic
Browse files Browse the repository at this point in the history
If we call __kvm_hyp_panic while a guest context is active, we call
__restore_sysregs before acquiring the system register values for the
panic, in the process throwing away the PAR_EL1 value at the point of
the panic.

This patch modifies __kvm_hyp_panic to stash the PAR_EL1 value prior to
restoring host register values, enabling us to report the original
values at the point of the panic.

Acked-by: Marc Zyngier <[email protected]>
Signed-off-by: Mark Rutland <[email protected]>
Signed-off-by: Christoffer Dall <[email protected]>
  • Loading branch information
Mark Rutland authored and chazy committed Nov 24, 2015
1 parent 1d7a4e3 commit fbb4574
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion arch/arm64/kvm/hyp.S
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,10 @@ ENTRY(__kvm_flush_vm_context)
ENDPROC(__kvm_flush_vm_context)

__kvm_hyp_panic:
// Stash PAR_EL1 before corrupting it in __restore_sysregs
mrs x0, par_el1
push x0, xzr

// Guess the context by looking at VTTBR:
// If zero, then we're already a host.
// Otherwise restore a minimal host context before panicing.
Expand Down Expand Up @@ -898,7 +902,7 @@ __kvm_hyp_panic:
mrs x3, esr_el2
mrs x4, far_el2
mrs x5, hpfar_el2
mrs x6, par_el1
pop x6, xzr // active context PAR_EL1
mrs x7, tpidr_el2

mov lr, #(PSR_F_BIT | PSR_I_BIT | PSR_A_BIT | PSR_D_BIT |\
Expand Down

0 comments on commit fbb4574

Please sign in to comment.