Skip to content

Commit

Permalink
i2c: mux: pinctrl: drop the idle_state member
Browse files Browse the repository at this point in the history
The information is available elsewhere.

Reviewed-by: Stephen Warren <[email protected]>
Signed-off-by: Peter Rosin <[email protected]>
  • Loading branch information
peda-r committed Aug 14, 2017
1 parent c4aee3e commit fc20467
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/i2c/muxes/i2c-mux-pinctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
struct i2c_mux_pinctrl {
struct pinctrl *pinctrl;
struct pinctrl_state **states;
struct pinctrl_state *state_idle;
};

static int i2c_mux_pinctrl_select(struct i2c_mux_core *muxc, u32 chan)
Expand All @@ -40,9 +39,7 @@ static int i2c_mux_pinctrl_select(struct i2c_mux_core *muxc, u32 chan)

static int i2c_mux_pinctrl_deselect(struct i2c_mux_core *muxc, u32 chan)
{
struct i2c_mux_pinctrl *mux = i2c_mux_priv(muxc);

return pinctrl_select_state(mux->pinctrl, mux->state_idle);
return i2c_mux_pinctrl_select(muxc, muxc->num_adapters);
}

static struct i2c_adapter *i2c_mux_pinctrl_root_adapter(
Expand Down Expand Up @@ -149,7 +146,6 @@ static int i2c_mux_pinctrl_probe(struct platform_device *pdev)
ret = -EINVAL;
goto err_put_parent;
}
mux->state_idle = mux->states[i];
muxc->deselect = i2c_mux_pinctrl_deselect;
}

Expand All @@ -166,7 +162,7 @@ static int i2c_mux_pinctrl_probe(struct platform_device *pdev)
dev_info(dev, "mux-locked i2c mux\n");

/* Do not add any adapter for the idle state (if it's there at all). */
for (i = 0; i < num_names - !!mux->state_idle; i++) {
for (i = 0; i < num_names - !!muxc->deselect; i++) {
ret = i2c_mux_add_adapter(muxc, 0, i, 0);
if (ret)
goto err_del_adapter;
Expand Down

0 comments on commit fc20467

Please sign in to comment.