Skip to content

Commit

Permalink
Exclude Positron dev extensions from package stream (posit-dev#2969)
Browse files Browse the repository at this point in the history
* exclude Positron dev extensions from package stream

* add change markers

* also exclude from REH builds
  • Loading branch information
jmcphers authored May 1, 2024
1 parent e36026b commit 16db730
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
14 changes: 13 additions & 1 deletion build/gulpfile.reh.js
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,14 @@ function packageTask(type, platform, arch, sourceFolderName, destinationFolderNa
}
}
};
// --- Start Positron ---
const excludedExtensions = [
'vscode-api-tests',
'vscode-test-resolver',
'positron-zed',
'positron-javascript',
];
// --- End Positron ---
const localWorkspaceExtensions = glob.sync('extensions/*/package.json')
.filter((extensionPath) => {
if (type === 'reh-web') {
Expand All @@ -270,7 +278,11 @@ function packageTask(type, platform, arch, sourceFolderName, destinationFolderNa
const manifest = JSON.parse(fs.readFileSync(path.join(REPO_ROOT, extensionPath)).toString());
return !isUIExtension(manifest);
}).map((extensionPath) => path.basename(path.dirname(extensionPath)))
.filter(name => name !== 'vscode-api-tests' && name !== 'vscode-test-resolver'); // Do not ship the test extensions
// --- Start Positron ---
// Add Positron dev extensions to the list that we don't ship with the REH
// .filter(name => name !== 'vscode-api-tests' && name !== 'vscode-test-resolver'); // Do not ship the test extensions
.filter(name => excludedExtensions.indexOf(name) === -1);
// --- End Positron ---
const marketplaceExtensions = JSON.parse(fs.readFileSync(path.join(REPO_ROOT, 'product.json'), 'utf8')).builtInExtensions
.filter(entry => !entry.platforms || new Set(entry.platforms).has(platform))
.filter(entry => !entry.clientOnly)
Expand Down
4 changes: 4 additions & 0 deletions build/lib/extensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,10 @@ const excludedExtensions = [
'vscode-test-resolver',
'ms-vscode.node-debug',
'ms-vscode.node-debug2',
// --- Start Positron ---
'positron-zed',
'positron-javascript',
// --- End Positron ---
];

const marketplaceWebExtensionsExclude = new Set([
Expand Down

0 comments on commit 16db730

Please sign in to comment.