Remove route event in componentWillUnmount (vercel#6196)

`Router.events.off` should be called instead of `Router.events.on` in `componentWillInmount`.
kylemac · Feb 3, 2019 · 0e13d8c · 0e13d8c
1 parent 5a4176c
commit 0e13d8c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/test/integration/with-router/components/header-nav.js b/test/integration/with-router/components/header-nav.js
@@ -26,7 +26,7 @@ class HeaderNav extends React.Component {
 
   componentWillUnmount () {
     Router.onRouteChangeComplete = null
-    Router.events.on('routeChangeComplete', this.handleRouteChangeTopLevelRouter)
+    Router.events.off('routeChangeComplete', this.handleRouteChangeTopLevelRouter)
     this.props.router.events.off('routeChangeComplete', this.handleRouteChange)
   }