Skip to content

Commit

Permalink
merge to redux-saga 1.0.0, api breaking changes included. (vercel#6109)
Browse files Browse the repository at this point in the history
Hi there
I noticed you have not yet included the api breaking changes in `"redux-saga": "1.0.0"`. Therefore I felt free to upgrade the dependencies in `examples/with-redux-saga`.
I do not know anything about apollo nor graphql, that is why I did not upgrade `examples/with-apollo-and-redux-saga`. But, I think you should do this on occasion.
Keep the great work up.
Regards
  • Loading branch information
bbortt authored and timneutkens committed Jan 25, 2019
1 parent 024323b commit 7adb6c5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
14 changes: 7 additions & 7 deletions examples/with-redux-saga/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@
"start": "next start"
},
"dependencies": {
"es6-promise": "4.1.1",
"isomorphic-unfetch": "2.0.0",
"es6-promise": "4.2.5",
"isomorphic-unfetch": "3.0.0",
"next": "latest",
"next-redux-saga": "3.0.0",
"next-redux-wrapper": "2.0.0",
"next-redux-wrapper": "2.1.0",
"react": "^16.7.0",
"react-dom": "^16.7.0",
"react-redux": "5.0.7",
"redux": "4.0.0",
"redux-saga": "0.16.0"
"react-redux": "6.0.0",
"redux": "4.0.1",
"redux-saga": "1.0.0"
},
"devDependencies": {
"redux-devtools-extension": "2.13.2"
"redux-devtools-extension": "2.13.7"
}
}
5 changes: 2 additions & 3 deletions examples/with-redux-saga/saga.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/* global fetch */

import { delay } from 'redux-saga'
import { all, call, put, take, takeLatest } from 'redux-saga/effects'
import { all, call, delay, put, take, takeLatest } from 'redux-saga/effects'
import es6promise from 'es6-promise'
import 'isomorphic-unfetch'

Expand All @@ -13,7 +12,7 @@ function * runClockSaga () {
yield take(actionTypes.START_CLOCK)
while (true) {
yield put(tickClock(false))
yield call(delay, 1000)
yield delay(1000)
}
}

Expand Down

0 comments on commit 7adb6c5

Please sign in to comment.