fix: be correct so we don't burn from Zs (#77)

* fix: be correct so we don't burn from Zs

* fix: remove comment

* fix: saturate instead of wrap

* Revert "fix: saturate instead of wrap"

This reverts commit d407e53.

* fix: remember the sign

src/stdlib/base.rs

@@ -44,10 +44,10 @@ pub fn load_base<'gc>(ctx: Context<'gc>) {
                         }
                     })
                     .try_fold(0i64, |acc, v| match v {
-                        Some(v) if v < base => Some(acc * base + v),
+                        Some(v) if v < base => Some(acc.wrapping_mul(base).wrapping_add(v)),
                         _ => None,
                     })
-                    .map(|v| v * sign);
+                    .map(|v| v.wrapping_mul(sign));
                 stack.replace(ctx, result.map(Value::Integer).unwrap_or(Value::Nil));
             }
 

tests/scripts/tonumber.lua

@@ -27,6 +27,8 @@ do
     assert(tonumber("1 1") == nil)
     assert(tonumber({}) == nil)
     assert(tonumber(nil) == nil)
+    assert(tonumber("ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ", 36) == -1)
+    assert(tonumber("-ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZAZZ", 36) == 32401)
     assert(tonumber("-3.51234567e7") == -35123456.7)
     assert(is_err(function() tonumber(3, 4) end))
     assert(is_err(function() tonumber(3., 4) end))