add test case to express.Router

labbsr0x · Jul 27, 2020 · 0021758 · 0021758
1 parent 3c52f52
commit 0021758
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/test/app_test.js b/test/app_test.js
@@ -9,6 +9,14 @@ app.get('/', (req, res) => {
 	res.send('test')
 })
 
+const router = express.Router()
+
+router.get('/testRouter', (req, res) => {
+	res.send("hello")
+})
+
+app.use('/router', router)
+
 
 
 module.exports = app
diff --git a/test/test_monitor.js b/test/test_monitor.js
@@ -18,7 +18,7 @@ describe('Collect metrics middleware', () => {
 			.get('/')
 			.set('Content-Type', 'application/json')
 			.send()
-			.end((err, res) => {
+			.end((err) => {
 				if(err) console.log(err)
 			})
 		chai.request(app)
@@ -32,4 +32,24 @@ describe('Collect metrics middleware', () => {
 				expect(res.text).to.include('response_size_bytes{type="http",status="200",method="GET",addr="/",isError="false",errorMessage=""}')
 			})
 	})
+
+	it('should collect metric from express.Router', () => {
+		chai.request(app)
+			.get('/router/testRouter')
+			.set('Content-Type', 'application/json')
+			.send()
+			.end((err) => {
+				if(err) console.log(err)
+			})
+		chai.request(app)
+			.get('/metrics')
+			.set('Content-Type', 'application/json')
+			.send()
+			.end((err, res) => {
+				expect(res.text).to.include('request_seconds_bucket{le="0.1",type="http",status="200",method="GET",addr="/router/testRouter",isError="false",errorMessage=""} 1')
+				expect(res.text).to.include('request_seconds_sum{type="http",status="200",method="GET",addr="/router/testRouter",isError="false",errorMessage=""}')
+				expect(res.text).to.include('request_seconds_count{type="http",status="200",method="GET",addr="/router/testRouter",isError="false",errorMessage=""} 1')
+				expect(res.text).to.include('response_size_bytes{type="http",status="200",method="GET",addr="/router/testRouter",isError="false",errorMessage=""}')
+			})
+	})
 })