dockerfiles/build.sh: fix buildx detection #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docker <subcommand> --help` cannot be used to detect whether a sub command is available because it exits with 0 no matter if the sub command exists or not. Use `docker buildx version` as a test for buildx support instead. Fixes: 17765c7 ("dockerfiles: support for docker/podman buildx") Reported-by: Sebastian Groß <[email protected]> Signed-off-by: Bastian Krause <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
======================================
Coverage 55.8% 55.8%
======================================
Files 170 170
Lines 13365 13365
======================================
Hits 7458 7458
Misses 5907 5907
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
LGTM |
Emantor
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
docker <subcommand> --helpcannot be used to detect whether a sub command is available because it exits with 0 no matter if the sub command exists or not.Use
docker buildx versionas a test for buildx support instead.Checklist
Fixes: #1585