-
Notifications
You must be signed in to change notification settings - Fork 79
Add deb task configuration allowing the auto-inclusion of resources #109
base: master
Are you sure you want to change the base?
Conversation
Allows the use of pre/post{inst,rm}, etc scripts. The `resources-dir` task setting should be set to the parent directory of a `debian` dir containing the resources.
@@ -131,7 +131,9 @@ func debDevBuild(tp TaskParams) error { | |||
build := debgen.NewBuildParams() | |||
build.DestDir = debDir | |||
build.TmpDir = tmpDir | |||
build.Init() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
This is great. Thanks for taking the time to dig in and see what's up. Please go ahead and merge. (see invite). |
There's actually a problem with the way debber handles this - resources appears to be the only way to get it to include Happy for me to work up a debber PR to split |
Yes, thank you. I can't honestly remember the details of how debber works right now (!) but it sounds like a sensible plan. Please make a PR, and then if it introduces any backwards-incompatibility problems I am happy to just fork it into an 0.4. I never got the API to a point where it seemed 100% right, so I'm happy to take changes on board. Really I'd love to spend some more time rounding out the debber project, but unfortunately/fortunately I just have a very busy life nowadays. ¯_(ツ)_/¯ |
Oh this is perfect! I was just wondering why my maintainer scripts didn't fire when installing the deb files. When do you guys think this fix can be merged to master? Is there anything I can do to help? |
@stamp, I've not forgotten about this, I just haven't had time to get to it yet. |
Np I actually found a workaround. I moved the debian folder to resources/debian instead and now it works fine. Just a warning that the control file is missing but it works great anyway. |
If you read my earlier comment (or install the resulting package) you'll discover the undesirable side-effect - a |
I made a fix: debber/debber-v0.3#3 What do you think? Seems to work fine in my environment at least. |
sorry, this is older than the sun itself. |
Allows the use of pre/post{inst,rm}, etc scripts. The
resources-dir
task setting should be set to the parent directory of a
debian
dircontaining the resources.