Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Add deb task configuration allowing the auto-inclusion of resources #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdf
Copy link
Collaborator

@pdf pdf commented Aug 16, 2016

Allows the use of pre/post{inst,rm}, etc scripts. The resources-dir
task setting should be set to the parent directory of a debian dir
containing the resources.

Allows the use of pre/post{inst,rm}, etc scripts.  The `resources-dir`
task setting should be set to the parent directory of a `debian` dir
containing the resources.
@@ -131,7 +131,9 @@ func debDevBuild(tp TaskParams) error {
build := debgen.NewBuildParams()
build.DestDir = debDir
build.TmpDir = tmpDir
build.Init()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@laher
Copy link
Owner

laher commented Aug 20, 2016

This is great. Thanks for taking the time to dig in and see what's up.

Please go ahead and merge. (see invite).

@pdf
Copy link
Collaborator Author

pdf commented Aug 21, 2016

There's actually a problem with the way debber handles this - resources appears to be the only way to get it to include debian contents in the control, however it doesn't exclude debian from data. Whilst doing the latter would be easy, I feel like these two mechanisms should really be decoupled - that would allow for a top-level debian directory, which feels more normal than having to nest it somewhere.

Happy for me to work up a debber PR to split debian handling out of resources?

@laher
Copy link
Owner

laher commented Aug 21, 2016

Yes, thank you. I can't honestly remember the details of how debber works right now (!) but it sounds like a sensible plan.

Please make a PR, and then if it introduces any backwards-incompatibility problems I am happy to just fork it into an 0.4. I never got the API to a point where it seemed 100% right, so I'm happy to take changes on board.

Really I'd love to spend some more time rounding out the debber project, but unfortunately/fortunately I just have a very busy life nowadays. ¯_(ツ)_/¯

@stamp
Copy link

stamp commented Oct 25, 2016

Oh this is perfect! I was just wondering why my maintainer scripts didn't fire when installing the deb files.

When do you guys think this fix can be merged to master? Is there anything I can do to help?

@pdf
Copy link
Collaborator Author

pdf commented Oct 25, 2016

@stamp, I've not forgotten about this, I just haven't had time to get to it yet.

@stamp
Copy link

stamp commented Oct 25, 2016

Np

I actually found a workaround. I moved the debian folder to resources/debian instead and now it works fine. Just a warning that the control file is missing but it works great anyway.

@pdf
Copy link
Collaborator Author

pdf commented Oct 25, 2016

If you read my earlier comment (or install the resulting package) you'll discover the undesirable side-effect - a debian directory will also be deployed to the filesystem because it ends up in the data tarball, which is probably not what you want.

@stamp
Copy link

stamp commented Oct 25, 2016

I made a fix: debber/debber-v0.3#3

What do you think? Seems to work fine in my environment at least.

@laher
Copy link
Owner

laher commented Oct 1, 2020

sorry, this is older than the sun itself.
I merged @stamp's debber PR FWIW.
I figure everyone's moved on with their lives since this was created. 🤷 many apologies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants