Skip to content

Commit

Permalink
memblock: replace alloc_bootmem with memblock_alloc
Browse files Browse the repository at this point in the history
The alloc_bootmem(size) is a shortcut for allocation of SMP_CACHE_BYTES
aligned memory. When the align parameter of memblock_alloc() is 0, the
alignment is implicitly set to SMP_CACHE_BYTES and thus alloc_bootmem(size)
and memblock_alloc(size, 0) are equivalent.

The conversion is done using the following semantic patch:

@@
expression size;
@@
- alloc_bootmem(size)
+ memblock_alloc(size, 0)

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Mike Rapoport <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Chris Zankel <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Greentime Hu <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Guan Xuetao <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: "James E.J. Bottomley" <[email protected]>
Cc: Jonas Bonn <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Cc: Ley Foon Tan <[email protected]>
Cc: Mark Salter <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
Cc: Matt Turner <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Palmer Dabbelt <[email protected]>
Cc: Paul Burton <[email protected]>
Cc: Richard Kuo <[email protected]>
Cc: Richard Weinberger <[email protected]>
Cc: Rich Felker <[email protected]>
Cc: Russell King <[email protected]>
Cc: Serge Semin <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: Vineet Gupta <[email protected]>
Cc: Yoshinori Sato <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
rppt authored and torvalds committed Oct 31, 2018
1 parent 4fc4a09 commit 2a5bda5
Show file tree
Hide file tree
Showing 19 changed files with 28 additions and 26 deletions.
4 changes: 2 additions & 2 deletions arch/alpha/kernel/core_marvel.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ mk_resource_name(int pe, int port, char *str)
char *name;

sprintf(tmp, "PCI %s PE %d PORT %d", str, pe, port);
name = alloc_bootmem(strlen(tmp) + 1);
name = memblock_alloc(strlen(tmp) + 1, 0);
strcpy(name, tmp);

return name;
Expand Down Expand Up @@ -117,7 +117,7 @@ alloc_io7(unsigned int pe)
return NULL;
}

io7 = alloc_bootmem(sizeof(*io7));
io7 = memblock_alloc(sizeof(*io7), 0);
io7->pe = pe;
raw_spin_lock_init(&io7->irq_lock);

Expand Down
4 changes: 2 additions & 2 deletions arch/alpha/kernel/pci-noop.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ alloc_pci_controller(void)
{
struct pci_controller *hose;

hose = alloc_bootmem(sizeof(*hose));
hose = memblock_alloc(sizeof(*hose), 0);

*hose_tail = hose;
hose_tail = &hose->next;
Expand All @@ -44,7 +44,7 @@ alloc_pci_controller(void)
struct resource * __init
alloc_resource(void)
{
return alloc_bootmem(sizeof(struct resource));
return memblock_alloc(sizeof(struct resource), 0);
}

SYSCALL_DEFINE3(pciconfig_iobase, long, which, unsigned long, bus,
Expand Down
4 changes: 2 additions & 2 deletions arch/alpha/kernel/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ alloc_pci_controller(void)
{
struct pci_controller *hose;

hose = alloc_bootmem(sizeof(*hose));
hose = memblock_alloc(sizeof(*hose), 0);

*hose_tail = hose;
hose_tail = &hose->next;
Expand All @@ -403,7 +403,7 @@ alloc_pci_controller(void)
struct resource * __init
alloc_resource(void)
{
return alloc_bootmem(sizeof(struct resource));
return memblock_alloc(sizeof(struct resource), 0);
}


Expand Down
4 changes: 2 additions & 2 deletions arch/alpha/kernel/pci_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ iommu_arena_new_node(int nid, struct pci_controller *hose, dma_addr_t base,
printk("%s: couldn't allocate arena from node %d\n"
" falling back to system-wide allocation\n",
__func__, nid);
arena = alloc_bootmem(sizeof(*arena));
arena = memblock_alloc(sizeof(*arena), 0);
}

arena->ptes = memblock_alloc_node(sizeof(*arena), align, nid);
Expand All @@ -92,7 +92,7 @@ iommu_arena_new_node(int nid, struct pci_controller *hose, dma_addr_t base,

#else /* CONFIG_DISCONTIGMEM */

arena = alloc_bootmem(sizeof(*arena));
arena = memblock_alloc(sizeof(*arena), 0);
arena->ptes = memblock_alloc_from(mem_size, align, 0);

#endif /* CONFIG_DISCONTIGMEM */
Expand Down
4 changes: 2 additions & 2 deletions arch/ia64/kernel/mca.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,9 @@ static ia64_state_log_t ia64_state_log[IA64_MAX_LOG_TYPES];

#define IA64_LOG_ALLOCATE(it, size) \
{ia64_state_log[it].isl_log[IA64_LOG_CURR_INDEX(it)] = \
(ia64_err_rec_t *)alloc_bootmem(size); \
(ia64_err_rec_t *)memblock_alloc(size, 0); \
ia64_state_log[it].isl_log[IA64_LOG_NEXT_INDEX(it)] = \
(ia64_err_rec_t *)alloc_bootmem(size);}
(ia64_err_rec_t *)memblock_alloc(size, 0);}
#define IA64_LOG_LOCK_INIT(it) spin_lock_init(&ia64_state_log[it].isl_lock)
#define IA64_LOG_LOCK(it) spin_lock_irqsave(&ia64_state_log[it].isl_lock, s)
#define IA64_LOG_UNLOCK(it) spin_unlock_irqrestore(&ia64_state_log[it].isl_lock,s)
Expand Down
4 changes: 2 additions & 2 deletions arch/ia64/mm/tlb.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ struct ia64_tr_entry *ia64_idtrs[NR_CPUS];
void __init
mmu_context_init (void)
{
ia64_ctx.bitmap = alloc_bootmem((ia64_ctx.max_ctx+1)>>3);
ia64_ctx.flushmap = alloc_bootmem((ia64_ctx.max_ctx+1)>>3);
ia64_ctx.bitmap = memblock_alloc((ia64_ctx.max_ctx + 1) >> 3, 0);
ia64_ctx.flushmap = memblock_alloc((ia64_ctx.max_ctx + 1) >> 3, 0);
}

/*
Expand Down
3 changes: 2 additions & 1 deletion arch/m68k/sun3/sun3dvma.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,8 @@ void __init dvma_init(void)

list_add(&(hole->list), &hole_list);

iommu_use = alloc_bootmem(IOMMU_TOTAL_ENTRIES * sizeof(unsigned long));
iommu_use = memblock_alloc(IOMMU_TOTAL_ENTRIES * sizeof(unsigned long),
0);

dvma_unmap_iommu(DVMA_START, DVMA_SIZE);

Expand Down
2 changes: 1 addition & 1 deletion arch/microblaze/mm/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ void * __ref zalloc_maybe_bootmem(size_t size, gfp_t mask)
if (mem_init_done)
p = kzalloc(size, mask);
else {
p = alloc_bootmem(size);
p = memblock_alloc(size, 0);
if (p)
memset(p, 0, size);
}
Expand Down
2 changes: 1 addition & 1 deletion arch/mips/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ static void __init resource_init(void)
if (end >= HIGHMEM_START)
end = HIGHMEM_START - 1;

res = alloc_bootmem(sizeof(struct resource));
res = memblock_alloc(sizeof(struct resource), 0);

res->start = start;
res->end = end;
Expand Down
2 changes: 1 addition & 1 deletion arch/um/drivers/net_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ static int __init eth_setup(char *str)
return 1;
}

new = alloc_bootmem(sizeof(*new));
new = memblock_alloc(sizeof(*new), 0);

INIT_LIST_HEAD(&new->list);
new->index = n;
Expand Down
2 changes: 1 addition & 1 deletion arch/um/drivers/vector_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -1580,7 +1580,7 @@ static int __init vector_setup(char *str)
str, error);
return 1;
}
new = alloc_bootmem(sizeof(*new));
new = memblock_alloc(sizeof(*new), 0);
INIT_LIST_HEAD(&new->list);
new->unit = n;
new->arguments = str;
Expand Down
2 changes: 1 addition & 1 deletion arch/um/kernel/initrd.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ int __init read_initrd(void)
return 0;
}

area = alloc_bootmem(size);
area = memblock_alloc(size, 0);

if (load_initrd(initrd, area, size) == -1)
return 0;
Expand Down
3 changes: 2 additions & 1 deletion arch/x86/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,8 @@ static int __init acpi_parse_hpet(struct acpi_table_header *table)
* the resource tree during the lateinit timeframe.
*/
#define HPET_RESOURCE_NAME_SIZE 9
hpet_res = alloc_bootmem(sizeof(*hpet_res) + HPET_RESOURCE_NAME_SIZE);
hpet_res = memblock_alloc(sizeof(*hpet_res) + HPET_RESOURCE_NAME_SIZE,
0);

hpet_res->name = (void *)&hpet_res[1];
hpet_res->flags = IORESOURCE_MEM;
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/kernel/apic/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -2578,7 +2578,7 @@ static struct resource * __init ioapic_setup_resources(void)
n = IOAPIC_RESOURCE_NAME_SIZE + sizeof(struct resource);
n *= nr_ioapics;

mem = alloc_bootmem(n);
mem = memblock_alloc(n, 0);
res = (void *)mem;

mem += sizeof(struct resource) * nr_ioapics;
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/kernel/e820.c
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@ void __init e820__reserve_resources(void)
struct resource *res;
u64 end;

res = alloc_bootmem(sizeof(*res) * e820_table->nr_entries);
res = memblock_alloc(sizeof(*res) * e820_table->nr_entries, 0);
e820_res = res;

for (i = 0; i < e820_table->nr_entries; i++) {
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/platform/olpc/olpc_dt.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ void * __init prom_early_alloc(unsigned long size)
* fast enough on the platforms we care about while minimizing
* wasted bootmem) and hand off chunks of it to callers.
*/
res = alloc_bootmem(chunk_size);
res = memblock_alloc(chunk_size, 0);
BUG_ON(!res);
prom_early_allocated += chunk_size;
memset(res, 0, chunk_size);
Expand Down
2 changes: 1 addition & 1 deletion arch/xtensa/platforms/iss/network.c
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ static int __init iss_net_setup(char *str)
return 1;
}

new = alloc_bootmem(sizeof(*new));
new = memblock_alloc(sizeof(*new), 0);
if (new == NULL) {
pr_err("Alloc_bootmem failed\n");
return 1;
Expand Down
2 changes: 1 addition & 1 deletion drivers/macintosh/smu.c
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ int __init smu_init (void)
goto fail_np;
}

smu = alloc_bootmem(sizeof(struct smu_device));
smu = memblock_alloc(sizeof(struct smu_device), 0);

spin_lock_init(&smu->lock);
INIT_LIST_HEAD(&smu->cmd_list);
Expand Down
4 changes: 2 additions & 2 deletions init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -773,8 +773,8 @@ static int __init initcall_blacklist(char *str)
str_entry = strsep(&str, ",");
if (str_entry) {
pr_debug("blacklisting initcall %s\n", str_entry);
entry = alloc_bootmem(sizeof(*entry));
entry->buf = alloc_bootmem(strlen(str_entry) + 1);
entry = memblock_alloc(sizeof(*entry), 0);
entry->buf = memblock_alloc(strlen(str_entry) + 1, 0);
strcpy(entry->buf, str_entry);
list_add(&entry->next, &blacklisted_initcalls);
}
Expand Down

0 comments on commit 2a5bda5

Please sign in to comment.