netfilter: nfnetlink: fix missing rcu_read_unlock in nfnetlink_rcv_msg

Bug added in commit 6b75e3e (netfilter: nfnetlink: add RCU in nfnetlink_rcv_msg()) Signed-off-by: Tomasz Bursztyka <[email protected]> Acked-by: Eric Dumazet <[email protected]> Signed-off-by: Pablo Neira Ayuso <[email protected]>
laijs · Jun 29, 2012 · 4009e18 · 4009e18
1 parent d31f4d4
commit 4009e18
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
@@ -169,8 +169,10 @@ static int nfnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
 
 		err = nla_parse(cda, ss->cb[cb_id].attr_count,
 				attr, attrlen, ss->cb[cb_id].policy);
-		if (err < 0)
+		if (err < 0) {
+			rcu_read_unlock();
 			return err;
+		}
 
 		if (nc->call_rcu) {
 			err = nc->call_rcu(net->nfnl, skb, nlh,