Skip to content

Commit

Permalink
X25 remove bkl from causediag ioctls
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Hendry <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
AndrewHendry authored and davem330 committed Nov 28, 2010
1 parent 5b7958d commit 74a7e44
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions net/x25/af_x25.c
Original file line number Diff line number Diff line change
Expand Up @@ -1538,23 +1538,22 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
}

case SIOCX25GCAUSEDIAG: {
struct x25_causediag causediag;
lock_kernel();
causediag = x25->causediag;
rc = copy_to_user(argp, &causediag,
sizeof(causediag)) ? -EFAULT : 0;
unlock_kernel();
lock_sock(sk);
rc = copy_to_user(argp, &x25->causediag,
sizeof(x25->causediag))
? -EFAULT : 0;
release_sock(sk);
break;
}

case SIOCX25SCAUSEDIAG: {
struct x25_causediag causediag;
rc = -EFAULT;
lock_kernel();
if (copy_from_user(&causediag, argp, sizeof(causediag)))
break;
lock_sock(sk);
x25->causediag = causediag;
unlock_kernel();
release_sock(sk);
rc = 0;
break;

Expand Down

0 comments on commit 74a7e44

Please sign in to comment.