Skip to content

Commit

Permalink
USB: omap_udc: use resource_size
Browse files Browse the repository at this point in the history
Use resource_size rather than a verbose computation on
the end and start fields.

The semantic patch that makes these changes is as follows:
(http://coccinelle.lip6.fr/)

<smpl>
@@ struct resource ptr; @@
- (ptr.end - ptr.start + 1)
+ resource_size(&ptr)
</smpl>

Signed-off-by: Julia Lawall <[email protected]>

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
JuliaLawall authored and gregkh committed Jan 8, 2020
1 parent 0e84f2f commit 7b7ad03
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/usb/gadget/udc/omap_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2757,7 +2757,7 @@ static int omap_udc_probe(struct platform_device *pdev)

/* NOTE: "knows" the order of the resources! */
if (!request_mem_region(pdev->resource[0].start,
pdev->resource[0].end - pdev->resource[0].start + 1,
resource_size(&pdev->resource[0]),
driver_name)) {
DBG("request_mem_region failed\n");
return -EBUSY;
Expand Down Expand Up @@ -2934,7 +2934,7 @@ static int omap_udc_probe(struct platform_device *pdev)
}

release_mem_region(pdev->resource[0].start,
pdev->resource[0].end - pdev->resource[0].start + 1);
resource_size(&pdev->resource[0]));

return status;
}
Expand All @@ -2950,7 +2950,7 @@ static int omap_udc_remove(struct platform_device *pdev)
wait_for_completion(&done);

release_mem_region(pdev->resource[0].start,
pdev->resource[0].end - pdev->resource[0].start + 1);
resource_size(&pdev->resource[0]));

return 0;
}
Expand Down

0 comments on commit 7b7ad03

Please sign in to comment.