Skip to content

Commit

Permalink
staging: wilc1000: move 'rcv_assoc_resp' as part of hif_drv
Browse files Browse the repository at this point in the history
Avoid use of static variable and move 'rcv_assoc_resp' as part of
'hif_drv' struct. Rename from 'rcv_assoc_resp' to 'assoc_resp'.

Signed-off-by: Ajay Singh <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
ajaykathat authored and gregkh committed Sep 10, 2018
1 parent 8b89ba7 commit 83a953e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/staging/wilc1000/host_interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,6 @@ static u8 p2p_listen_state;
static struct completion hif_driver_comp;
static struct mutex hif_deinit_lock;

static u8 rcv_assoc_resp[MAX_ASSOC_RESP_FRAME_SIZE];

static u8 set_ip[2][4];
static u8 get_ip[2][4];

Expand Down Expand Up @@ -1502,16 +1500,16 @@ static inline void host_int_parse_assoc_resp_info(struct wilc_vif *vif,
if (mac_status == MAC_STATUS_CONNECTED) {
u32 assoc_resp_info_len;

memset(rcv_assoc_resp, 0, MAX_ASSOC_RESP_FRAME_SIZE);
memset(hif_drv->assoc_resp, 0, MAX_ASSOC_RESP_FRAME_SIZE);

host_int_get_assoc_res_info(vif, rcv_assoc_resp,
host_int_get_assoc_res_info(vif, hif_drv->assoc_resp,
MAX_ASSOC_RESP_FRAME_SIZE,
&assoc_resp_info_len);

if (assoc_resp_info_len != 0) {
s32 err = 0;

err = wilc_parse_assoc_resp_info(rcv_assoc_resp,
err = wilc_parse_assoc_resp_info(hif_drv->assoc_resp,
assoc_resp_info_len,
&conn_info);
if (err)
Expand Down
1 change: 1 addition & 0 deletions drivers/staging/wilc1000/host_interface.h
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ struct host_if_drv {

bool ifc_up;
int driver_handler_id;
u8 assoc_resp[MAX_ASSOC_RESP_FRAME_SIZE];
};

struct add_sta_param {
Expand Down

0 comments on commit 83a953e

Please sign in to comment.