Skip to content

Commit

Permalink
leds: tlc591xx: update the maximum brightness
Browse files Browse the repository at this point in the history
The TLC chips actually offer 257 levels:
- 0: led OFF
- 1-255: Led dimmed is using a PWM. The duty cycle range from 0.4% to 99.6%
- 256: led fully ON

Fixes: e370d01 ("leds: tlc591xx: Driver for the TI 8/16 Channel i2c LED driver")
Signed-off-by: Jean-Jacques Hiblot <[email protected]>
Signed-off-by: Pavel Machek <[email protected]>
  • Loading branch information
Jean-Jacques Hiblot authored and pavelmachek committed Nov 3, 2019
1 parent da61a66 commit a2cafdf
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/leds/leds-tlc591xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include <linux/slab.h>

#define TLC591XX_MAX_LEDS 16
#define TLC591XX_MAX_BRIGHTNESS 256

#define TLC591XX_REG_MODE1 0x00
#define MODE1_RESPON_ADDR_MASK 0xF0
Expand Down Expand Up @@ -112,11 +113,11 @@ tlc591xx_brightness_set(struct led_classdev *led_cdev,
struct tlc591xx_priv *priv = led->priv;
int err;

switch (brightness) {
switch ((int)brightness) {
case 0:
err = tlc591xx_set_ledout(priv, led, LEDOUT_OFF);
break;
case LED_FULL:
case TLC591XX_MAX_BRIGHTNESS:
err = tlc591xx_set_ledout(priv, led, LEDOUT_ON);
break;
default:
Expand Down Expand Up @@ -209,7 +210,7 @@ tlc591xx_probe(struct i2c_client *client,
led->priv = priv;
led->led_no = reg;
led->ldev.brightness_set_blocking = tlc591xx_brightness_set;
led->ldev.max_brightness = LED_FULL;
led->ldev.max_brightness = TLC591XX_MAX_BRIGHTNESS;
err = devm_led_classdev_register_ext(dev, &led->ldev,
&init_data);
if (err < 0) {
Expand Down

0 comments on commit a2cafdf

Please sign in to comment.