Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
compiler-intel: fix wrong compiler barrier() macro
Cleanup commit 73679e5 ("compiler-intel.h: Remove duplicate definition") removed the double definition of __memory_barrier() intrinsics. However, in doing so, it also removed the preceding #undef barrier by accident, meaning, the actual barrier() macro from compiler-gcc.h with inline asm is still in place as __GNUC__ is provided. Subsequently, barrier() can never be defined as __memory_barrier() from compiler.h since it already has a definition in place and if we trust the comment in compiler-intel.h, ecc doesn't support gcc specific asm statements. I don't have an ecc at hand (unsure if that's still used in the field?) and only found this by accident during code review, a revert of that cleanup would be simplest option. Fixes: 73679e5 ("compiler-intel.h: Remove duplicate definition") Signed-off-by: Daniel Borkmann <[email protected]> Reviewed-by: Pranith Kumar <[email protected]> Cc: Pranith Kumar <[email protected]> Cc: H. Peter Anvin <[email protected]> Cc: mancha security <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
- Loading branch information