Skip to content

Commit

Permalink
kconfig: fix broken dependency in randconfig-generated .config
Browse files Browse the repository at this point in the history
Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5)
produces the .config with CONFIG_EFI=y and CONFIG_CPU_BIG_ENDIAN=y,
which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.

This is because the user choice for CONFIG_CPU_LITTLE_ENDIAN vs
CONFIG_CPU_BIG_ENDIAN is set by randomize_choice_values() after the
value of CONFIG_EFI is calculated.

When this happens, the has_changed flag should be set.

Currently, it takes the result from the last iteration. It should
accumulate all the results of the loop.

Fixes: 3b9a19e ("kconfig: loop as long as we changed some symbols in randconfig")
Reported-by: Vincenzo Frascino <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
  • Loading branch information
masahir0y committed Feb 3, 2020
1 parent 754beee commit c8fb7d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/kconfig/confdata.c
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode)

sym_calc_value(csym);
if (mode == def_random)
has_changed = randomize_choice_values(csym);
has_changed |= randomize_choice_values(csym);
else {
set_all_choice_values(csym);
has_changed = true;
Expand Down

0 comments on commit c8fb7d7

Please sign in to comment.