[ISSUE alibaba#5080] Fix health checker pre-start logic. (alibaba#5081)

lakecenter · Mar 12, 2021 · 4acb695 · 4acb695
1 parent 481d25a
commit 4acb695
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...main/java/com/alibaba/nacos/naming/healthcheck/v2/processor/HttpHealthCheckProcessor.java b/...main/java/com/alibaba/nacos/naming/healthcheck/v2/processor/HttpHealthCheckProcessor.java
@@ -73,7 +73,7 @@ public void process(HealthCheckTaskV2 task, Service service, ClusterMetadata met
         }
         try {
             // TODO handle marked(white list) logic like v1.x.
-            if (instance.tryStartCheck()) {
+            if (!instance.tryStartCheck()) {
                 SRV_LOG.warn("http check started before last one finished, service: {} : {} : {}:{}",
                         service.getGroupedServiceName(), instance.getCluster(), instance.getIp(), instance.getPort());
                 healthCheckCommon

diff --git a/...ain/java/com/alibaba/nacos/naming/healthcheck/v2/processor/MysqlHealthCheckProcessor.java b/...ain/java/com/alibaba/nacos/naming/healthcheck/v2/processor/MysqlHealthCheckProcessor.java
@@ -86,7 +86,7 @@ public void process(HealthCheckTaskV2 task, Service service, ClusterMetadata met
         SRV_LOG.debug("mysql check, ip:" + instance);
         try {
             // TODO handle marked(white list) logic like v1.x.
-            if (instance.tryStartCheck()) {
+            if (!instance.tryStartCheck()) {
                 SRV_LOG.warn("mysql check started before last one finished, service: {} : {} : {}:{}",
                         service.getGroupedServiceName(), instance.getCluster(), instance.getIp(), instance.getPort());
                 healthCheckCommon

diff --git a/.../main/java/com/alibaba/nacos/naming/healthcheck/v2/processor/TcpHealthCheckProcessor.java b/.../main/java/com/alibaba/nacos/naming/healthcheck/v2/processor/TcpHealthCheckProcessor.java
@@ -100,7 +100,7 @@ public void process(HealthCheckTaskV2 task, Service service, ClusterMetadata met
             return;
         }
         // TODO handle marked(white list) logic like v1.x.
-        if (instance.tryStartCheck()) {
+        if (!instance.tryStartCheck()) {
             SRV_LOG.warn("tcp check started before last one finished, service: {} : {} : {}:{}",
                     service.getGroupedServiceName(), instance.getCluster(), instance.getIp(), instance.getPort());
             healthCheckCommon