Don't warn when Error() is used without 'new'.

Closes jshint#1590.
lama-akeila · Mar 26, 2014 · 2fecdea · 2fecdea
1 parent 7320df1
commit 2fecdea
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/jshint.js b/src/jshint.js
@@ -1037,7 +1037,7 @@ var JSHINT = (function () {
   }
 
 
-// Functions for conformance of style.
+  // Functions for conformance of style.
 
   function nobreaknonadjacent(left, right) {
     left = left || state.tokens.curr;
@@ -2442,7 +2442,7 @@ var JSHINT = (function () {
     if (left) {
       if (left.type === "(identifier)") {
         if (left.value.match(/^[A-Z]([A-Z0-9_$]*[a-z][A-Za-z0-9_$]*)?$/)) {
-          if ("Number String Boolean Date Object".indexOf(left.value) === -1) {
+          if ("Number String Boolean Date Object Error".indexOf(left.value) === -1) {
             if (left.value === "Math") {
               warning("W063", left);
             } else if (state.option.newcap) {

diff --git a/tests/unit/fixtures/newcap.js b/tests/unit/fixtures/newcap.js
@@ -11,3 +11,9 @@ var bat = new myAnimal();
 
 rat = iAnimal();
 bat = myAnimal();
+
+// Make sure we don't warn on Error, Number, etc.
+Error();
+Number();
+String();
+Boolean();