Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial grammar for impl blocks and optimize grammar [3] #153

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 9, 2025

Initial grammar for impl blocks

Depends on #152

Copy link

github-actions bot commented Jan 9, 2025

Benchmarking factorial

Compiling factorial (factorial.con)
Finished release in 30.811412ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 59.35 ms
Rust Result = 2432902008176640000 Time taken : 60.38 ms

Benchmarking fib

Compiling fib (fib.con)
Finished release in 26.116828ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 136.69 ms
Rust Result = 6765 Time taken : 86.16 ms

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (d854690) to head (5d075e0).

Files with missing lines Patch % Lines
src/ir/lowering.rs 18.18% 9 Missing ⚠️
src/ir/lowering/prepass.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   62.70%   62.54%   -0.16%     
==========================================
  Files          20       20              
  Lines        4673     4680       +7     
==========================================
- Hits         2930     2927       -3     
- Misses       1743     1753      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l changed the title Add initial grammar for impl blocks Add initial grammar for impl blocks and optimize grammar Jan 9, 2025
@edg-l edg-l mentioned this pull request Jan 10, 2025
@edg-l edg-l mentioned this pull request Jan 13, 2025
@edg-l edg-l changed the title Add initial grammar for impl blocks and optimize grammar Add initial grammar for impl blocks and optimize grammar [3] Jan 13, 2025
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests?

@edg-l
Copy link
Member Author

edg-l commented Jan 14, 2025

Can you add some tests?

they are added in the next pr

Base automatically changed from refactor_lower_type to main January 14, 2025 13:52
@edg-l edg-l enabled auto-merge January 14, 2025 13:58
@edg-l edg-l added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit d786c3b Jan 14, 2025
7 checks passed
@edg-l edg-l deleted the impl_grammar branch January 14, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants