Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check locals exist before they are used (in more cases) #171

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Feb 4, 2025

Fixes #170

Copy link

github-actions bot commented Feb 4, 2025

Benchmarking factorial

Compiling factorial (factorial.con)
Finished release in 30.90627ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 59.85 ms
Rust Result = 2432902008176640000 Time taken : 60.66 ms

Benchmarking fib

Compiling fib (fib.con)
Finished release in 27.053328ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 136.68 ms
Rust Result = 6765 Time taken : 85.67 ms

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.98%. Comparing base (f1d57cd) to head (35d5f05).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   63.90%   63.98%   +0.08%     
==========================================
  Files          21       21              
  Lines        4956     4968      +12     
==========================================
+ Hits         3167     3179      +12     
  Misses       1789     1789              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l force-pushed the check_use_of_undeclared_var branch from b3fdedf to 35d5f05 Compare February 4, 2025 14:28
@edg-l edg-l added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit de0d968 Feb 6, 2025
7 checks passed
@edg-l edg-l deleted the check_use_of_undeclared_var branch February 6, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowed usage of locals before their definition in a scope
4 participants