Add composer conflict with incompatible service-manager release #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autowire factory Laminas\Di\Container\ServiceManager\AutowireFactory is not compatible with the interface of laminas-service-manager 4.0. Signed-off-by: tux-rampage <[email protected]>
tux-rampage
added
Bug
Ocramius
approved these changes
Nov 20, 2024
| "laminas/laminas-servicemanager": "<3.13.0" | ||
| "laminas/laminas-servicemanager": "<3.13.0 || >=4.0.0" |
There was a problem hiding this comment.
OK, but composer.lock needs adjustment.
Also, older releases still affected :O
There was a problem hiding this comment.
True. Another option would be to add a conflict to laminas/laminas-service-manager with "laminas/laminas-di": "<4.0.0" as well.
Anyways composer may still pick two incompatible versions if the constraints are low enough.
Signed-off-by: tux-rampage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As detected in #92, the autowire factory
Laminas\Di\Container\ServiceManager\AutowireFactoryis not compatible with the interface oflaminas-service-managerVersion4.0.0and newer.This should be reflected in the composer dependency definition.