Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Check organism parameter type in curator #2297

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Dec 18, 2024

Fixes #2293

Now ensuring that people don't pass Organism to organism of any Curator but an actual str (the Organism name)

I am generally pretty unhappy about the fact that the Curator takes organism str but some other functions require an actual Organism and do not take str. It's inconsistent.

@Zethson Zethson marked this pull request as ready for review December 18, 2024 12:11
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (2a17099) to head (fb14c5c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
+ Coverage   92.82%   92.86%   +0.04%     
==========================================
  Files          55       55              
  Lines        7202     7216      +14     
==========================================
+ Hits         6685     6701      +16     
+ Misses        517      515       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zethson Zethson merged commit 337c7f9 into main Dec 18, 2024
15 checks passed
@Zethson Zethson deleted the feature/defensive_organism branch December 18, 2024 12:48
Copy link

@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 12:53 Inactive
@Zethson Zethson changed the title 🎨 Add defensive organism check 🎨 Check organism parameter type in curator Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_new_from_var_index leads to unique key value error because it attempts to save values with no source again
1 participant