Better out of capacity error (MystenLabs#1711)

lamtac6814 · May 3, 2022 · 300f32d · 300f32d
1 parent 1a25e68
commit 300f32d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/sui_core/src/consensus_adapter.rs b/sui_core/src/consensus_adapter.rs
@@ -212,9 +212,11 @@ impl ConsensusListener {
                     match message {
                         // Keep track of this certificates so we can notify the user later.
                         ConsensusListenerMessage::New(transaction, replier) => {
+                            let digest = Self::hash(&transaction);
                             if self.pending.len() < self.max_pending_transactions {
-                                let digest = Self::hash(&transaction);
                                 self.pending.entry(digest).or_insert_with(Vec::new).push(replier);
+                            } else if replier.send(Err(SuiError::ListenerCapacityExceeded)).is_err() {
+                                debug!("No replier to listen to consensus output {digest}");
                             }
                         },
 

diff --git a/sui_core/tests/staged/sui.yaml b/sui_core/tests/staged/sui.yaml
@@ -729,12 +729,14 @@ SuiError:
       SharedObjectLockingFailure:
         NEWTYPE: STR
     98:
+      ListenerCapacityExceeded: UNIT
+    99:
       SignatureSeedInvalidLength:
         NEWTYPE: U64
-    99:
+    100:
       HkdfError:
         NEWTYPE: STR
-    100:
+    101:
       SignatureKeyGenError:
         NEWTYPE: STR
 TransactionData:

diff --git a/sui_types/src/error.rs b/sui_types/src/error.rs
@@ -302,12 +302,12 @@ pub enum SuiError {
     // Errors related to the authority-consensus interface.
     #[error("Authority state can be modified by a single consensus client at the time")]
     OnlyOneConsensusClientPermitted,
-
     #[error("Failed to connect with consensus node: {0}")]
     ConsensusConnectionBroken(String),
-
     #[error("Failed to lock shared objects: {0}")]
     SharedObjectLockingFailure(String),
+    #[error("Consensus listener is out of capacity")]
+    ListenerCapacityExceeded,
 
     // Cryptography errors.
     #[error("Signature seed invalid length, input byte size was: {0}")]