[jquery] scrollLeft() and scrollTop() can also return undefined.

scrollLeft() and scrollTop() will return undefined when used on an empty set.
lance · Jul 11, 2017 · 1c6c4aa · 1c6c4aa
1 parent f5fd92f
commit 1c6c4aa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/types/jquery/index.d.ts b/types/jquery/index.d.ts
@@ -2845,7 +2845,7 @@ interface JQuery<TElement extends Node = HTMLElement> extends Iterable<TElement>
      * @see {@link https://api.jquery.com/scrollLeft/}
      * @since 1.2.6
      */
-    scrollLeft(): number;
+    scrollLeft(): number | undefined;
     /**
      * Set the current vertical position of the scroll bar for each of the set of matched elements.
      *
@@ -2861,7 +2861,7 @@ interface JQuery<TElement extends Node = HTMLElement> extends Iterable<TElement>
      * @see {@link https://api.jquery.com/scrollTop/}
      * @since 1.2.6
      */
-    scrollTop(): number;
+    scrollTop(): number | undefined;
     /**
      * Bind an event handler to the "select" JavaScript event, or trigger that event on an element.
      *

diff --git a/types/jquery/jquery-tests.ts b/types/jquery/jquery-tests.ts
@@ -1936,15 +1936,15 @@ function JQuery() {
             // $ExpectType JQuery<HTMLElement>
             $('p').scrollLeft(200);
 
-            // $ExpectType number
+            // $ExpectType number | undefined
             $('p').scrollLeft();
         }
 
         function scrollTop() {
             // $ExpectType JQuery<HTMLElement>
             $('p').scrollTop(200);
 
-            // $ExpectType number
+            // $ExpectType number | undefined
             $('p').scrollTop();
         }