Remove unused layer override

lancemk · Mar 5, 2023 · 9d5c9c2 · 9d5c9c2
1 parent 9427b41
commit 9d5c9c2
Show file tree

Hide file tree

Showing 4 changed files with 70 additions and 24 deletions.
diff --git a/packages/noya-file-format/src/types.ts b/packages/noya-file-format/src/types.ts
@@ -1181,21 +1181,7 @@ export type OverrideValue = {
   _class: 'overrideValue';
   do_objectID?: Uuid;
   overrideName: OverrideName;
-  value:
-    | boolean
-    | string
-    | Uuid
-    | FileRef
-    | DataRef
-    | ResolvedBlockData
-    | LayersOverrideValue;
-};
-
-export type LayersOverrideValue = {
-  layers: Pick<
-    SymbolInstance,
-    'do_objectID' | 'symbolID' | 'blockText' | 'resolvedBlockData'
-  >[];
+  value: boolean | string | Uuid | FileRef | DataRef | ResolvedBlockData;
 };
 
 /**

diff --git a/packages/noya-state/src/overrides.ts b/packages/noya-state/src/overrides.ts
@@ -28,7 +28,6 @@ export type PropertyTypeMap = {
   blockText: string;
   resolvedBlockData: Sketch.ResolvedBlockData;
   isVisible: boolean;
-  layers: Sketch.LayersOverrideValue;
 };
 
 export type PropertyType = keyof PropertyTypeMap;
@@ -66,8 +65,6 @@ export function getLayerOverride(
   value: PropertyValue,
 ) {
   switch (propertyType) {
-    case 'layers':
-      return { type: propertyType, value, layer } as const;
     case 'isVisible': {
       if (!isValidProperty(propertyType, value)) return;
 

diff --git a/packages/site/src/__tests__/__snapshots__/renderBlock.test.ts.snap b/packages/site/src/__tests__/__snapshots__/renderBlock.test.ts.snap
@@ -100,6 +100,36 @@ exports[`hero default 1`] = `
 "
 `;
 
+exports[`hero left aligned 1`] = `
+"<Frame width={400} height={400}>
+  <Flex
+    width=\\"400px\\"
+    height=\\"400px\\"
+    className=\\"flex-col bg-transparent p-4 gap-3 items-start justify-center\\"
+  >
+    <Flex>
+      <Heading flex=\\"1\\" size=\\"xl\\" lineHeight=\\"1.3\\" textAlign=\\"left\\">
+        {'Create, iterate, inspire.'}
+      </Heading>
+    </Flex>
+    <Text className=\\"mb-4\\" textAlign=\\"left\\">
+      {'Turn great ideas into new possibilities.'}
+    </Text>
+    <Flex className=\\"bg-transparent flex-row items-center gap-6\\">
+      <Button
+        size=\\"md\\"
+        backgroundColor=\\"#15803d\\"
+        color=\\"#fff\\"
+        isDisabled={false}
+      >
+        {'Get started'}
+      </Button>
+    </Flex>
+  </Flex>
+</Frame>;
+"
+`;
+
 exports[`hero left aligned default 1`] = `
 "<Frame width={400} height={400}>
   <Flex
@@ -130,6 +160,43 @@ exports[`hero left aligned default 1`] = `
 "
 `;
 
+exports[`hero with bg 1`] = `
+"<Frame width={400} height={400}>
+  <Flex
+    width=\\"400px\\"
+    height=\\"400px\\"
+    className=\\"flex-col bg-blue-500 p-4 gap-3 items-center justify-center\\"
+  >
+    <Flex>
+      <Heading
+        flex=\\"1\\"
+        size=\\"xl\\"
+        lineHeight=\\"1.3\\"
+        className=\\"text-white\\"
+        textAlign=\\"center\\"
+      >
+        {'Create, iterate, inspire.'}
+      </Heading>
+    </Flex>
+    <Text className=\\"mb-4 text-white\\" textAlign=\\"center\\">
+      {'Turn great ideas into new possibilities.'}
+    </Text>
+    <Flex className=\\"bg-transparent flex-row items-center gap-6\\">
+      <Button
+        size=\\"md\\"
+        backgroundColor=\\"#f1f5f9\\"
+        color=\\"#000\\"
+        isDisabled={false}
+        className=\\"text-white\\"
+      >
+        {'Get started'}
+      </Button>
+    </Flex>
+  </Flex>
+</Frame>;
+"
+`;
+
 exports[`hero with bg default 1`] = `
 "<Frame width={400} height={400}>
   <Flex

diff --git a/packages/site/src/__tests__/renderBlock.test.ts b/packages/site/src/__tests__/renderBlock.test.ts
@@ -125,10 +125,8 @@ describe('hero', () => {
 
     expect(generate(symbol)).toMatchSnapshot();
   });
-});
 
-describe('hero left aligned', () => {
-  test('default', () => {
+  test('left aligned', () => {
     const symbol = SketchModel.symbolInstance({
       symbolID: heroSymbolV2Id,
       frame: SketchModel.rect({
@@ -140,10 +138,8 @@ describe('hero left aligned', () => {
 
     expect(generate(symbol)).toMatchSnapshot();
   });
-});
 
-describe('hero with bg', () => {
-  test('default', () => {
+  test('with bg', () => {
     const symbol = SketchModel.symbolInstance({
       symbolID: heroSymbolV2Id,
       frame: SketchModel.rect({