delete Transaction Metadata

Closes: aptos-labs#165
lanlan23 · Mar 13, 2022 · 8dda1fc · 8dda1fc
1 parent e2b018b
commit 8dda1fc
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 53 deletions.
diff --git a/documentation/specifications/transactions/onchain/README.md b/documentation/specifications/transactions/onchain/README.md
@@ -4,18 +4,7 @@ Diem transactions mutate and create state (or resources) within the set of [on-c
 
 ## Peer to Peer Payments and Transaction Metadata
 
-Most transactions will use the [peer_to_peer_with_metadata script function](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/script_documentation/script_documentation.md#0x1_PaymentScripts_peer_to_peer_with_metadata). This single transaction represents all current transfers between two participants and distinguishes the types of transfers via the embedded metadata.
-
-The metadata is represented by the following `Rust` enum encoded in [Binary Canonical Serialization (BCS)](https://github.com/diem/bcs):
-
-```
-enum Metadata {
-  Undefined,
-  UnstructuredByteMetadata(Option<Vec<u8>>),
-}
-```
-
-Note: This is the canonical list and should be referred to in future DIPs so that authors need not reproduce the list in future DIPs.
+Most transactions will use the [peer_to_peer_with_metadata script function](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/script_documentation/script_documentation.md#0x1_PaymentScripts_peer_to_peer_with_metadata). This single transaction represents all current transfers between two participants.
 
 ## Dual Attestation Credentials
 

diff --git a/testsuite/generate-format/src/aptos.rs b/testsuite/generate-format/src/aptos.rs
@@ -55,7 +55,6 @@ pub fn get_registry() -> Result<Registry> {
     // 2. Trace the main entry point(s) + every enum separately.
     tracer.trace_type::<contract_event::ContractEvent>(&samples)?;
     tracer.trace_type::<language_storage::TypeTag>(&samples)?;
-    tracer.trace_type::<transaction::metadata::Metadata>(&samples)?;
     tracer.trace_type::<transaction::Transaction>(&samples)?;
     tracer.trace_type::<transaction::TransactionArgument>(&samples)?;
     tracer.trace_type::<transaction::VecBytes>(&samples)?;

diff --git a/testsuite/generate-format/tests/staged/aptos.yaml b/testsuite/generate-format/tests/staged/aptos.yaml
@@ -69,14 +69,6 @@ HashValue:
   NEWTYPESTRUCT: BYTES
 Identifier:
   NEWTYPESTRUCT: STR
-Metadata:
-  ENUM:
-    0:
-      Undefined: UNIT
-    1:
-      UnstructuredBytesMetadata:
-        NEWTYPE:
-          TYPENAME: UnstructuredBytesMetadata
 Module:
   STRUCT:
     - code: BYTES
@@ -249,10 +241,6 @@ TypeTag:
       Struct:
         NEWTYPE:
           TYPENAME: StructTag
-UnstructuredBytesMetadata:
-  STRUCT:
-    - metadata:
-        OPTION: BYTES
 VecBytes:
   NEWTYPESTRUCT:
     SEQ: BYTES

diff --git a/types/src/transaction/metadata.rs b/types/src/transaction/metadata.rs
diff --git a/types/src/transaction/mod.rs b/types/src/transaction/mod.rs
@@ -40,7 +40,6 @@ use std::{
 pub mod authenticator;
 mod change_set;
 pub mod helpers;
-pub mod metadata;
 mod module;
 mod script;
 mod transaction_argument;

diff --git a/types/src/unit_tests/transaction_test.rs b/types/src/unit_tests/transaction_test.rs
@@ -6,9 +6,8 @@ use crate::{
     account_config::XUS_NAME,
     chain_id::ChainId,
     transaction::{
-        metadata, AccountTransactionsWithProof, RawTransaction, Script, SignedTransaction,
-        Transaction, TransactionInfo, TransactionListWithProof, TransactionPayload,
-        TransactionWithProof,
+        AccountTransactionsWithProof, RawTransaction, Script, SignedTransaction, Transaction,
+        TransactionInfo, TransactionListWithProof, TransactionPayload, TransactionWithProof,
     },
 };
 use aptos_crypto::{