Skip to content

Commit

Permalink
* object.c (rb_Hash): add Kernel#Hash conversion method like
Browse files Browse the repository at this point in the history
  Array() or Float().  a patch from Run Paint Run Run.  Fix ruby#3131

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@34367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
matz committed Jan 24, 2012
1 parent ac2683c commit 498838c
Show file tree
Hide file tree
Showing 4 changed files with 53 additions and 0 deletions.
5 changes: 5 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
Tue Jan 24 12:58:41 2012 Yukihiro Matsumoto <[email protected]>

* object.c (rb_Hash): add Kernel#Hash conversion method like
Array() or Float(). a patch from Run Paint Run Run. Fix #3131

Tue Jan 24 11:38:05 2012 NARUSE, Yui <[email protected]>

* lib/uri/common.rb (URI.encode_www_form_component): initialize on
Expand Down
1 change: 1 addition & 0 deletions include/ruby/intern.h
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,7 @@ VALUE rb_to_float(VALUE);
VALUE rb_Float(VALUE);
VALUE rb_String(VALUE);
VALUE rb_Array(VALUE);
VALUE rb_Hash(VALUE);
double rb_cstr_to_dbl(const char*, int);
double rb_str_to_dbl(VALUE, int);
/* parse.y */
Expand Down
34 changes: 34 additions & 0 deletions object.c
Original file line number Diff line number Diff line change
Expand Up @@ -2594,6 +2594,39 @@ rb_f_array(VALUE obj, VALUE arg)
return rb_Array(arg);
}

VALUE
rb_Hash(VALUE val)
{
if (NIL_P(val)) return rb_hash_new();
VALUE tmp = rb_check_hash_type(val);
if (NIL_P(tmp)) {
if (TYPE(val) == T_ARRAY && RARRAY_LEN(val) == 0)
return rb_hash_new();
rb_raise(rb_eTypeError, "can't convert %s into Hash", rb_obj_classname(val));
}
return tmp;
}

/*
* call-seq:
* Hash(arg) -> hash
*
* Converts <i>arg</i> to a <code>Hash</code> by calling
* <i>arg</i><code>.to_hash</code>. Returns an empty <code>Hash</code> when
* <i>arg</i> is <tt>nil</tt> or <tt>[]</tt>.
*
* Hash([]) #=> {}
* Hash(nil) #=> nil
* Hash(key: :value) #=> {:key => :value}
* Hash([1, 2, 3]) #=> TypeError
*/

static VALUE
rb_f_hash(VALUE obj, VALUE arg)
{
return rb_Hash(arg);
}

/*
* Document-class: Class
*
Expand Down Expand Up @@ -2839,6 +2872,7 @@ Init_Object(void)

rb_define_global_function("String", rb_f_string, 1);
rb_define_global_function("Array", rb_f_array, 1);
rb_define_global_function("Hash", rb_f_hash, 1);

rb_cNilClass = rb_define_class("NilClass", rb_cObject);
rb_define_method(rb_cNilClass, "to_i", nil_to_i, 0);
Expand Down
13 changes: 13 additions & 0 deletions test/ruby/test_object.rb
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,19 @@ def o.respond_to?(*) false; end
assert_equal([o], Array(o))
end

def test_convert_hash
assert_equal(Hash(nil), {})
assert_equal(Hash([]), {})
assert_equal(Hash(key: :value), {key: :value})
assert_raise(TypeError) { Hash([1,2]) }
assert_raise(TypeError) { Hash(Object.new) }
o = Object.new
def o.to_hash; {a: 1, b: 2}; end
assert_equal(Hash(o), {a: 1, b: 2})
def o.to_hash; 9; end
assert_raise(TypeError) { Hash(o) }
end

def test_to_integer
o = Object.new
def o.to_i; nil; end
Expand Down

0 comments on commit 498838c

Please sign in to comment.