Skip to content

Commit

Permalink
Revert "Added boolean type to database dialects."
Browse files Browse the repository at this point in the history
This reverts commit 1dbc01e.

Commit accidentally merged into master
  • Loading branch information
niden committed Jul 9, 2013
1 parent 7dc4370 commit d5f1dcd
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 22 deletions.
7 changes: 1 addition & 6 deletions ext/db/dialect/mysql.c
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,7 @@ PHP_METHOD(Phalcon_Db_Dialect_Mysql, getColumnDefinition){
}

break;

case 8:
PHALCON_INIT_VAR(column_sql);
ZVAL_STRING(column_sql, "TINYINT(1)", 1);
break;


default:
PHALCON_THROW_EXCEPTION_STR(phalcon_db_exception_ce, "Unrecognized MySQL data type");
return;
Expand Down
7 changes: 1 addition & 6 deletions ext/db/dialect/oracle.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,7 @@ PHP_METHOD(Phalcon_Db_Dialect_Oracle, getColumnDefinition){
PHALCON_INIT_NVAR(column_sql);
PHALCON_CONCAT_SVSVS(column_sql, "FLOAT(", size, ",", scale, ")");
break;

case 8:
PHALCON_INIT_VAR(column_sql);
ZVAL_STRING(column_sql, "TINYINT(1)", 1);
break;


default:
PHALCON_THROW_EXCEPTION_STR(phalcon_db_exception_ce, "Unrecognized Oracle data type");
return;
Expand Down
5 changes: 0 additions & 5 deletions ext/db/dialect/postgresql.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,6 @@ PHP_METHOD(Phalcon_Db_Dialect_Postgresql, getColumnDefinition){
PHALCON_INIT_NVAR(column_sql);
ZVAL_STRING(column_sql, "FLOAT", 1);
break;

case 8:
PHALCON_INIT_VAR(column_sql);
ZVAL_STRING(column_sql, "SMALLINT(1)", 1);
break;

default:
PHALCON_THROW_EXCEPTION_STR(phalcon_db_exception_ce, "Unrecognized PostgreSQL data type");
Expand Down
5 changes: 0 additions & 5 deletions ext/db/dialect/sqlite.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ PHP_METHOD(Phalcon_Db_Dialect_Sqlite, getColumnDefinition){
PHALCON_INIT_NVAR(column_sql);
ZVAL_STRING(column_sql, "FLOAT", 1);
break;

case 8:
PHALCON_INIT_VAR(column_sql);
ZVAL_STRING(column_sql, "TINYINT(1)", 1);
break;

default:
PHALCON_THROW_EXCEPTION_STR(phalcon_db_exception_ce, "Unrecognized SQLite data type");
Expand Down

0 comments on commit d5f1dcd

Please sign in to comment.