Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return collection of responses from send #179

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Return collection of responses from send #179

merged 2 commits into from
Dec 24, 2023

Conversation

dwightwatson
Copy link
Collaborator

  • send will now return a collection of MulticastSendReport instead of void. This is optional, it will still return void if there are no tokens provided.
  • Not sure if there is a better object to return - but considering we do chunk results we sort of have to return the results in a batch also.
  • Remove docblocks that are now covered by type hints instead.

Closes #178.

@dwightwatson
Copy link
Collaborator Author

I wonder if I should return an array instead?

@kohenkatz
Copy link

I wonder if I should return an array instead?

I believe the previous version returned an array, but I don't think that is a reason to need to return an array from this version. Collection implements the array interface, so I think older code that worked with version 3 should still work.

I have not tested this PR yet, but it looks good to me.

@dwightwatson dwightwatson merged commit 3cdf1e4 into master Dec 24, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 4.x breaks Laravel's NotificationSent event
2 participants