修复：测试失败时日志文件未删除 (overtrue#318)

* Add @after annotation to unlink log file after tests * Add Mockery global helpers back
larvatecn · Nov 19, 2021 · a76bd3e · a76bd3e
1 parent 94de413
commit a76bd3e
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 7 deletions.
diff --git a/tests/Gateways/ErrorlogGatewayTest.php b/tests/Gateways/ErrorlogGatewayTest.php
@@ -19,11 +19,20 @@
 
 class ErrorlogGatewayTest extends TestCase
 {
+    protected $logFile = 'easy-sms-error-log-mock-file.log';
+
+    /**
+     * @after
+     */
+    public function removeLogFile()
+    {
+        unlink($this->logFile);
+    }
+
     public function testSend()
     {
-        $logFile = 'easy-sms-error-log-mock-file.log';
         $gateway = new ErrorlogGateway([
-            'file' => $logFile,
+            'file' => $this->logFile,
         ]);
 
         $message = new Message([
@@ -33,13 +42,12 @@ public function testSend()
 
         $gateway->send(new PhoneNumber(new PhoneNumber(18188888888)), $message, new Config());
 
-        $this->assertTrue(file_exists($logFile));
-        $this->assertFalse(
+        $this->assertTrue(file_exists($this->logFile));
+        $this->assertNotFalse(
             strpos(
-                'to: 18188888888 | message: "This is a test message."  | template: "" | data: {"foo":"bar"}',
-                file_get_contents($logFile)
+                file_get_contents($this->logFile),
+                'to: 18188888888 | message: "This is a test message."  | template: "" | data: {"foo":"bar"}'
             )
         );
-        unlink($logFile);
     }
 }
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -11,6 +11,23 @@
 
 namespace Overtrue\EasySms\Tests;
 
+use Mockery;
+
 class TestCase extends \PHPUnit\Framework\TestCase
 {
+    /**
+     * @before
+     */
+    public function registerMockery()
+    {
+        Mockery::globalHelpers();
+    }
+
+    /**
+     * @after
+     */
+    public function closeMockery()
+    {
+        Mockery::close();
+    }
 }