fix return type of getopt_long

On some platforms this manifested as an inability to parse command line
arguments and login.  Fixes:

lpass.c:58:2: warning: comparison is always true due to limited range of
data type [-Wtype-limits]
  while ((option = getopt_long(argc, argv, "vh", long_options,
&option_index)) != -1) {
  ^
Signed-off-by: Bob Copeland <[email protected]>

cmd-duplicate.c

@@ -24,7 +24,7 @@ int cmd_duplicate(int argc, char **argv)
 		{"sync", required_argument, NULL, 'S'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	char *name;
 	enum blobsync sync = BLOB_SYNC_AUTO;

cmd-edit.c

@@ -117,7 +117,7 @@ int cmd_edit(int argc, char **argv)
 		{"non-interactive", no_argument, NULL, 'X'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	enum { NONE, USERNAME, PASSWORD, URL, FIELD, NAME, NOTES } choice = NONE;
 	_cleanup_free_ char *field = NULL;

cmd-export.c

@@ -56,7 +56,7 @@ int cmd_export(int argc, char **argv)
 		{"csv", required_argument, NULL, 'C'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	enum blobsync sync = BLOB_SYNC_AUTO;
 	enum { CSV } choice = CSV;

cmd-login.c

@@ -24,7 +24,7 @@ int cmd_login(int argc, char **argv)
 		{"force", no_argument, NULL, 'f'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	bool trust = false;
 	bool plaintext_key = false;

cmd-logout.c

@@ -21,7 +21,7 @@ int cmd_logout(int argc, char **argv)
 		{"force", no_argument, NULL, 'f'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	bool force = false;
 	struct session *session = NULL;

cmd-ls.c

@@ -96,7 +96,7 @@ int cmd_ls(int argc, char **argv)
 		{"sync", required_argument, NULL, 'S'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	char *group = NULL;
 	int group_len;

cmd-rm.c

@@ -24,7 +24,7 @@ int cmd_rm(int argc, char **argv)
 		{"sync", required_argument, NULL, 'S'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	char *name;
 	enum blobsync sync = BLOB_SYNC_AUTO;

cmd-show.c

@@ -58,7 +58,7 @@ int cmd_show(int argc, char **argv)
 		{"clip", no_argument, NULL, 'c'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	enum { ALL, USERNAME, PASSWORD, URL, FIELD, ID, NAME, NOTES } choice = ALL;
 	_cleanup_free_ char *field = NULL;

cmd-sync.c

@@ -24,7 +24,7 @@ int cmd_sync(int argc, char **argv)
 		{"background", no_argument, NULL, 'b'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 	bool background = false;
 

lpass.c

@@ -53,7 +53,7 @@ static int global_options(int argc, char *argv[])
 		{"help", no_argument, NULL, 'h'},
 		{0, 0, 0, 0}
 	};
-	char option;
+	int option;
 	int option_index;
 
 	while ((option = getopt_long(argc, argv, "vh", long_options, &option_index)) != -1) {